Jens Geyer created THRIFT-6316:
----------------------------------
Summary: Fetch the test and tutorial JavaScript libraries over
HTTPS
Key: THRIFT-6316
URL: https://issues.apache.org/jira/browse/THRIFT-6316
Project: Thrift
Issue Type: Improvement
Components: JavaScript - Library, Tutorial, Test Suite
Reporter: Jens Geyer
The test build and two test pages fetch jQuery, QUnit and DataTables over plain
HTTP:
* {{lib/js/test/build.xml}} lines 99-101 -- the ant {{download_jslibs}} target
* {{test/index.html}} and {{test/features/index.html}} lines 25-27 -- the
result pages
* {{tutorial/js/tutorial.html}} line 31
Every one of these hosts serves the same bytes over HTTPS. Fetched both ways
and compared:
{code}
code.jquery.com/jquery-1.11.3.min.js http=895323ed2f72
https=895323ed2f72
code.jquery.com/jquery-2.1.3.min.js http=32015dd42e95
https=32015dd42e95
code.jquery.com/qunit/qunit-2.6.2.js http=30a6d6eb1814
https=30a6d6eb1814
code.jquery.com/qunit/qunit-2.6.2.css http=f8fe3e1935e7
https=f8fe3e1935e7
ajax.googleapis.com/.../jquery/1.4.2/... http=10092eee563d
https=10092eee563d
{code}
{{cdn.datatables.net}} answers HTTP with a 301 to HTTPS already, so the two
pages take the
redirect on every load today.
Verified after the change: {{ant download_jslibs}} in {{lib/js/test}} is BUILD
SUCCESSFUL and
writes jquery.js (95957 bytes), qunit.js (151757) and qunit.css (7875), the
same sizes the HTTP
URLs return.
Out of scope:
* {{lib/ts/test/build.xml}} -- [PR
#3747|https://github.com/apache/thrift/pull/3747] already moves
its four QUnit URLs to HTTPS; its one remaining jQuery line belongs in that
PR.
* The W3C validator badge {{<a href>}} and {{<img src>}} in nine test pages:
those are links and
images, not code the pages execute.
Drafted with AI assistance (Claude Opus 5).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
