Volodymyr Panivko created THRIFT-6323:
-----------------------------------------
Summary: Fix PHPUnit deprecations and notices in PHP test suite
Key: THRIFT-6323
URL: https://issues.apache.org/jira/browse/THRIFT-6323
Project: Thrift
Issue Type: Improvement
Components: PHP - Library
Reporter: Volodymyr Panivko
The PHP test suite currently triggers PHPUnit deprecations and notices when
running under PHPUnit 13:
* 1 runner deprecation: phpunit.xml uses deprecated cacheResult attribute.
* Multiple mock-object notices: tests use createMock() without configuring
expectations.
* Multiple any() invocation-count deprecations on function mocks.
These warnings are pre-existing and not caused by recent deprecation-removal
work, but they clutter CI output and will become hard errors with PHPUnit 14.
This task is to clean them up by:
1. Replacing cacheResult with recordTestRunHistory in lib/php/phpunit.xml.
2. Using createStub() instead of createMock() for objects that only define
return values.
3. Replacing expects(any()) with concrete invocation counts or stubs on
function mocks.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
