Volodymyr Panivko created THRIFT-6335:
-----------------------------------------

             Summary: Remove obsolete PHP version checks from ReflectionHelper
                 Key: THRIFT-6335
                 URL: https://issues.apache.org/jira/browse/THRIFT-6335
             Project: Thrift
          Issue Type: Task
          Components: PHP - Library
            Reporter: Volodymyr Panivko


The PHP test ReflectionHelper still checks PHP_VERSION_ID < 80100 before 
calling ReflectionMethod::setAccessible(true) and 
ReflectionProperty::setAccessible(true). The project already requires PHP 8.1, 
so neither branch executes on supported runtimes.

Remove both obsolete branches, simplify the reflection accessors, and update 
their descriptions. Keep the helper methods used by the existing tests. The 
minimum PHP version remains 8.1.

Validation should cover private-property reads/writes and private-method 
invocation on PHP 8.1, the existing PHP unit tests, and the PHP coding standard.

Generated-by: OpenAI Codex (GPT-6)




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to