Jens-G opened a new pull request, #3935: URL: https://github.com/apache/thrift/pull/3935
No CI job ran the C (GLib) library's tests: every `build.yml` job configures with `--without-c_glib`, and the static analysis job builds `lib/c_glib` only to run cppcheck. This adds a `lib-c_glib` job, like the ones added for D, Erlang, Lua and JavaScript: - It configures with `--with-c_glib --with-cpp`. configure looks for zlib only when C++ is enabled, and the c_glib zlib transport and the two C++ interop tests in `lib/c_glib/test` need it. The configure step fails unless GLib, the C++ library and zlib were all found, so the job cannot go green without testing anything. - It builds `libthrift` and `libthriftz`, `lib/c_glib`, and the precross target of `test/c_glib` (`testthrifttest` links its test handler), then runs `make -C lib/c_glib/test check-am`. Plain `make check` would also enter `lib/c_glib/test/fuzz`, whose fuzz targets have no `main()` under gcc. - It runs on ubuntu-22.04: with the GLib 2.80 of ubuntu-24.04, three tests stop on GLib criticals (THRIFT-5680). - The ubuntu-24.04 compiler build needs glibc 2.38 and does not start on ubuntu-22.04, so the compiler job's ubuntu-22.04 leg now also uploads its build, as `thrift-compiler-ubuntu-22.04`. The existing `thrift-compiler` artifact is unchanged. ### How it was checked The job's own `run:` blocks, taken from the YAML, were run under `bash -e` in an `ubuntu:jammy` container, with a compiler built by the compiler job's steps on 22.04 and handed over under the new artifact name: - the configure step fails when GLib, the C++ library or zlib is missing, and passes with all three; - all 31 tests in `lib/c_glib/test` pass, including the zlib transport tests and both C++ interop clients (that was before THRIFT-5881 added `testfinalize`, which this PR's own run covers); - zizmor reports nothing new. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
