slachiewicz opened a new pull request, #3939: URL: https://github.com/apache/thrift/pull/3939
A D service's exception aliases were written in pointer order, from a `std::set<t_type*>`, so the generated file could differ between runs. They now come out in the order the functions first throw them. Verified: `--gen d` over every `.thrift` in the repository → only the alias order in `CassandraTest.thrift` changes. - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? [THRIFT-6341](https://issues.apache.org/jira/browse/THRIFT-6341) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? - [x] Did you do your best to avoid breaking changes? No: only the order of alias declarations changes. - [x] Code change, so the commit carries no CI-skip marker. - [x] Tests: `compiler/cpp/tests/d/t_d_generator_exception_alias_tests.cc`, which fails without the fix; d generator tests are switched on. - [x] AI-assisted: the commit carries a `Co-Authored-By:` trailer. No new dependency or third-party code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
