slachiewicz opened a new pull request, #3940: URL: https://github.com/apache/thrift/pull/3940
`--gen haxe` wrote `(byte)N` and `(short)N` for i8 and i16 values, in constants and container literals. Neither is Haxe, and both types are `haxe.Int32`; the values are now plain integers, as for i32. Verified: `--gen haxe` over every `.thrift` in the repository → only the casts disappear, in 46 files. - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? [THRIFT-6342](https://issues.apache.org/jira/browse/THRIFT-6342) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? - [x] Did you do your best to avoid breaking changes? No: the affected files did not compile. - [x] Code change, so the commit carries no CI-skip marker. - [x] Tests: `compiler/cpp/tests/haxe/t_haxe_generator_const_tests.cc`, which fails without the fix; haxe generator tests are switched on. - [x] AI-assisted: the commit carries a `Co-Authored-By:` trailer. No new dependency or third-party code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
