slachiewicz opened a new pull request, #3941: URL: https://github.com/apache/thrift/pull/3941
The D reserved-word list had `"macro "` with a trailing space, so a field or function named `macro` was never escaped. It is now written as `macro_`, like `mixin_`. - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? [THRIFT-6344](https://issues.apache.org/jira/browse/THRIFT-6344) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? - [x] Did you do your best to avoid breaking changes? Only for an IDL with a member named `macro`, whose D output did not compile. - [x] Code change, so the commit carries no CI-skip marker. - [x] Tests: `compiler/cpp/tests/d/t_d_generator_reserved_word_tests.cc`, which fails without the fix; d generator tests are switched on (the same line as in THRIFT-6341). - [x] AI-assisted: the commit carries a `Co-Authored-By:` trailer. No new dependency or third-party code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
