HampusAdolfsson opened a new pull request, #3952: URL: https://github.com/apache/thrift/pull/3952
<!-- Explain the changes in the pull request below: --> With `js:node,esm`, a service that extends another service imported its parent with `require()`. This throws `require is not defined in ES module scope` when Node loads the `.mjs` file. This PR generates `import * as Parent from './Parent.mjs';` instead. The non-ESM output is unchanged. Test: `lib/nodejs/test/service_extends.test.mjs` generates a derived service in the es5, es6 and esm variants and checks that the inherited client and processor methods exist. Without the fix, the esm variant fails to load. <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? THRIFT-6368 - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] ~If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.~ <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
