Volodymyr Panivko created THRIFT-6372:
-----------------------------------------
Summary: Make PHP redirect helpers instance methods
Key: THRIFT-6372
URL: https://issues.apache.org/jira/browse/THRIFT-6372
Project: Thrift
Issue Type: Task
Components: PHP - Library
Reporter: Volodymyr Panivko
Assignee: Volodymyr Panivko
Fix For: 0.26.0
Make TCurlClient::redirectWithinOrigin() and TCurlClient::originOf() private
instance methods and update their call sites to use $this. Redirect validation
and request behavior remain unchanged.
This is a separate refactoring follow-up to THRIFT-6362 / PR #3933. THRIFT-6362
is already resolved for 0.25.0; this follow-up targets master for 0.26.0 and
needs its own issue for release tracking.
Pull request: https://github.com/apache/thrift/pull/3946
The PR reports validation on PHP 8.2.30 with PHPUnit 10.5.65: all 31
TCurlClientTest cases and 4 TCurlClientRedirectTest cases pass, along with
PHPCS for the changed PHP file and git diff --check. Full make style was
unavailable in the unconfigured worktree.
Generated-by: Codex (GPT-6)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
