Jens-G opened a new pull request, #3955:
URL: https://github.com/apache/thrift/pull/3955

   The netstd tutorial server stopped at startup with `-tr:http`:
   
   ```
   System.InvalidOperationException: Multiple constructors accepting all given 
argument types have been found in type 
'Thrift.Transport.Server.THttpServerTransport'. There should only be one 
applicable constructor.
   ```
   
   `app.UseMiddleware<THttpServerTransport>()` leaves ASP.NET Core only the 
`RequestDelegate` to match, and all three public `THttpServerTransport` 
constructors accept one. The tutorial now also passes the processor and a 
`TConfiguration`.
   
   Test: no CI job builds or runs `tutorial/netstd`, so I checked it by hand on 
master with the .NET 10.0.401 SDK, server and client in one container. Without 
the change, `Server -tr:http` aborts with the exception above. With it, the 
server starts and `Client -tr:http` completes all its calls. `-tr:tcp` does not 
go through this code and still works.
   
   The tutorial client's `-mc` option has a problem of its own. That is 
THRIFT-6375 and not part of this change.
   
   JIRA: [THRIFT-6374](https://issues.apache.org/jira/browse/THRIFT-6374)
   
   - [x] Apache Jira ticket: THRIFT-6374
   - [x] PR title follows "THRIFT-NNNN: describe my issue"
   - [x] Single commit
   - [x] No breaking change: tutorial code only.
   - [x] Code change, so the commit carries no CI-skip marker.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to