slachiewicz opened a new pull request, #3966: URL: https://github.com/apache/thrift/pull/3966
The generated `byte[] getX()` now assigns the right-sized buffer directly instead of going through `setX()`, whose `copyBinary` copied the bytes on every call. The method still returns the field's own array, as before. This is the part of THRIFT-6080 that changes no behaviour; union getters, `bufferForX()` and `unsafe_binaries` are left for the discussion on the ticket. Verified: the new TestStruct case fails without the change; `gradle test` in lib/java → 379 passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
