Jens Geyer created THRIFT-6401:
----------------------------------
Summary: Declare the minimum Visual C++ runtime for WinGet and
Chocolatey, and drop the dead Chocolatey icon
Key: THRIFT-6401
URL: https://issues.apache.org/jira/browse/THRIFT-6401
Project: Thrift
Issue Type: Bug
Components: Build Process
Reporter: Jens Geyer
The Chocolatey review of the {{thrift}} 0.25.0 package flagged two things in
{{build/windows/chocolatey/thrift.nuspec.in}}:
* The {{iconUrl}}, {{https://thrift.apache.org/assets/images/thrift-logo.svg}},
returns 404. The project has no square logo to point at instead, so the package
goes without an icon, as the 0.12.0 package did.
* The {{vcredist140}} dependency names no version. The released {{thrift.exe}}
links the shared Visual C++ runtime, and Microsoft requires the installed
redistributable to be at least as new as the build tools the program was built
with. {{thrift-0.25.0.exe}} reports linker version 14.51. Without a minimum,
any {{vcredist140}} that is already installed satisfies the dependency and is
not updated.
The WinGet installer manifest declares {{Microsoft.VCRedist.2015+.x64}} without
a minimum as well.
h2. Change
* The Chocolatey package drops {{iconUrl}} and asks for {{vcredist140}} 14.51
or later.
* The WinGet installer manifest asks for {{Microsoft.VCRedist.2015+.x64}} 14.51
or later, through {{MinimumVersion}}.
* The tests check both minimums, that the two agree, and that the Chocolatey
package names no icon.
* {{doc/ReleaseManagement.md}} says to raise the minimum when the compiler is
built with newer build tools, and {{build/windows/README.md}} mentions it.
The 0.25.0 Chocolatey package is still in moderation, so it can be pushed again
with the same version once this is merged.
_Drafted with AI assistance (Claude Opus 5.5)._
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
