soenkeliebau commented on issue #19: Create a first implementation of a 
asciidoctor block processor
URL: https://github.com/apache/incubator-training/pull/19#issuecomment-494700096
 
 
   The SO answer in question is [this 
one](https://stackoverflow.com/questions/35274068/rendering-xml-from-draw-io-as-an-image-using-mxcellrenderer).
   
   Code that I took is 
[here](https://github.com/apache/incubator-training/pull/19/commits/8ac5e13996bb4cdd022af6242aee960627788e60#diff-e6ee7387bc0f9aa6bae0c2a4e12a2a0dR55).
   
   The code looks very similar, identical in places, I agree. Then again I'd 
argue, that this is API usage, not actual logic that was implemented, so even 
if I rewrote this myself it would still look almost the same.
   Not sure what the rules around these things are..
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to