RyanSkraba commented on a change in pull request #43: Refactored the template
configuration to a common parent and introduced Maven archetype
URL: https://github.com/apache/incubator-training/pull/43#discussion_r329471776
##########
File path: tools/content-parent-pom/pom.xml
##########
@@ -196,16 +196,76 @@
<filtering>true</filtering>
<targetPath>${project.slides.directory}/reveal.js-${revealjs.version}/css/theme</targetPath>
</resource>
- <!-- Patch one of the "slim" files as the
'docinfo' integration doesn't seem to work -->
- <resource>
- <directory>libs/docinfo-hack</directory>
-
<targetPath>${project.build.directory}/asciidoctor-reveal.js-${asciidoctor-revealjs.version}/templates</targetPath>
- </resource>
</resources>
</configuration>
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.1.1</version>
+ <executions>
+ <execution>
+ <id>copy-training-asciidoc-resources</id>
+ <phase>generate-resources</phase>
+ <goals>
+ <goal>unpack</goal>
+ </goals>
+ <configuration>
+ <artifactItems>
+ <artifactItem>
+ <groupId>org.apache.training</groupId>
Review comment:
It looks like `content-master-resources` is built *after*
`content-parent-pom` if you run mvn install from the root directory of the
project.
I'm not sure this is intended! Should `content-parent-pom` add a dependency
on `content-master-resource`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
