RyanSkraba commented on pull request #65:
URL: https://github.com/apache/incubator-training/pull/65#issuecomment-634707433


   Hello!  The presentation looks like it's in good shape.
   
   If I understand correctly, each presentation should have it's own directory 
(and pom.xml), although you can have multiple translations for the presentation 
in the same directory.  
[Zookeeper](https://github.com/apache/incubator-training/tree/master/content/ZooKeeper/src/main/asciidoc)
 is an example with English and German.
   
   If you're planning expanding, we might want to consider directories such as 
`ComDev/Intro/` and `ComDev/NextSteps/` etc.
   
   It looks like other presentations use ["your name 
here"](https://github.com/apache/incubator-training/commit/d82271c3392831653ebf66a03b90a2b5d621ecda#diff-c6e3dab0415c4e5001fa9c751c15b92fL23-L24)
 instead of the original presenters names for checked in materials.  I have no 
strong opinion about it!  Either way, a new presenter will have little work to 
do.
   
   Let me know if you want to think about this more or commit it as is!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to