lfrancke commented on code in PR #84: URL: https://github.com/apache/incubator-training/pull/84#discussion_r1180393087
########## site/src/site/asciidoc/developers/website.adoc: ########## @@ -38,7 +38,7 @@ This allows us to generate images like the ones on the http://plc4x.apache.org/p === Providing new content -Within the `src/site` directory, there is a file `site.xml` which generally controls the menu and the look of the site. +The website content can be found on GitHub, in the /site subdirectory, at https://github.com/apache/incubator-training:"github.com/apache/incubator-training";. Within the `src/site` directory, there is a file `site.xml` which generally controls the menu and the look of the site. Review Comment: Should this be a proper Asciidoc link instead? I have to admit that my Asciidoc knowledge is a bit outdated but I'm not sure how that would currently be rendered https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#links ```suggestion The website content can be found on GitHub, in the /site subdirectory, at https://github.com/apache/incubator-training[github.com/apache/incubator-training]. Within the `src/site` directory, there is a file `site.xml` which generally controls the menu and the look of the site. ``` I have to be honest that I'm not entirely sure if my syntax is correct either... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@training.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
