JackieTien97 commented on code in PR #81:
URL: https://github.com/apache/tsfile/pull/81#discussion_r1606747881
##########
java/tsfile/src/main/java/org/apache/tsfile/write/record/datapoint/BinaryDataPoint.java:
##########
@@ -30,14 +30,14 @@
*
* @see DataPoint DataPoint
*/
-public class StringDataPoint extends DataPoint {
+public class BinaryDataPoint extends DataPoint {
Review Comment:
keep it as `StringDataPoint` to keep compatibility
##########
java/tsfile/src/main/java/org/apache/tsfile/file/metadata/statistics/BlobStatistics.java:
##########
@@ -58,7 +58,10 @@ int serializeStats(OutputStream outputStream) throws
IOException {
}
public void updateStats(Binary value) {
- // do nothing
+ // if (isEmpty) {
+ // System.out.println("set isEmpty to false");
+ isEmpty = false;
+ // }
Review Comment:
```suggestion
isEmpty = false;
```
##########
java/tsfile/pom.xml:
##########
@@ -35,6 +35,11 @@
<tsfile.ut.skip>${tsfile.test.skip}</tsfile.ut.skip>
</properties>
<dependencies>
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
+ <version>1.3.13</version>
+ </dependency>
Review Comment:
did tsfile module need this dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
