lancelly commented on code in PR #119:
URL: https://github.com/apache/tsfile/pull/119#discussion_r1642204650
##########
java/tsfile/src/main/java/org/apache/tsfile/read/reader/page/AlignedPageReader.java:
##########
@@ -92,6 +94,38 @@ public AlignedPageReader(
this.valueCount = valuePageReaderList.size();
}
+ @TestOnly
+ public AlignedPageReader(
+ PageHeader timePageHeader,
+ ByteBuffer timePageData,
+ Decoder timeDecoder,
+ List<PageHeader> valuePageHeaderList,
+ List<ByteBuffer> valuePageDataList,
+ List<TSDataType> valueDataTypeList,
+ List<Decoder> valueDecoderList,
+ Filter globalTimeFilter,
+ boolean isLazyLoaded) {
Review Comment:
I changed to LazyLoadPageData[].
##########
java/tsfile/src/test/java/org/apache/tsfile/read/reader/AlignedPageReaderPushDownTest.java:
##########
@@ -137,7 +137,8 @@ private AlignedPageReader generateAlignedPageReader(
valuePageDataList,
valueDataTypeList,
valueDecoderList,
- globalTimeFilter);
+ globalTimeFilter,
+ false);
Review Comment:
Done.
##########
java/tsfile/src/test/java/org/apache/tsfile/read/reader/AlignedPageReaderPushDownTest.java:
##########
@@ -163,7 +164,8 @@ private AlignedPageReader
generateSingleColumnAlignedPageReader(
valuePageDataList,
valueDataTypeList,
valueDecoderList,
- globalTimeFilter);
+ globalTimeFilter,
+ false);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
