761417898 commented on code in PR #123:
URL: https://github.com/apache/tsfile/pull/123#discussion_r1644293910
##########
cpp/src/encoding/bitpack_encoder.h:
##########
@@ -81,7 +81,7 @@ class BitPackEncoder {
bit_width_ = get_int_max_bit_width(values_);
ASSERT(packer_ == nullptr);
packer_ = new IntPacker(bit_width_);
- common::SerializationUtil::write_i32(bit_width_, byte_cache_);
+ common::SerializationUtil::write_i8(bit_width_, byte_cache_);
Review Comment:
FORCE_INLINE static int write_i8(int8_t i8, ByteStream &out) {
return write_ui8((uint8_t)i8, out);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]