Sh-Zh-7 commented on code in PR #172:
URL: https://github.com/apache/tsfile/pull/172#discussion_r1673489855
##########
java/tsfile/src/main/java/org/apache/tsfile/read/filter/operator/ValueFilterOperators.java:
##########
@@ -794,6 +886,16 @@ public boolean valueSatisfy(Object value) {
return !candidates.contains(value);
}
+ @Override
+ protected boolean canSkip(Statistics<? extends Serializable> statistics) {
+ throw new NotImplementedException();
Review Comment:
Anyway, return false won't be wrong. Fixed.
##########
java/tsfile/src/main/java/org/apache/tsfile/read/filter/operator/ValueFilterOperators.java:
##########
@@ -794,6 +886,16 @@ public boolean valueSatisfy(Object value) {
return !candidates.contains(value);
}
+ @Override
+ protected boolean canSkip(Statistics<? extends Serializable> statistics) {
+ throw new NotImplementedException();
+ }
+
+ @Override
+ protected boolean allSatisfy(Statistics<? extends Serializable>
statistics) {
+ throw new NotImplementedException();
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
