JackieTien97 commented on code in PR #200:
URL: https://github.com/apache/tsfile/pull/200#discussion_r1703935817
##########
java/tsfile/src/main/java/org/apache/tsfile/utils/ReadWriteIOUtils.java:
##########
@@ -95,6 +95,12 @@ public static boolean readBool(ByteBuffer buffer) {
return a == 1;
}
+ /** read a bool from byteBuffer. */
+ public static boolean readBoolean(ByteBuffer buffer) {
Review Comment:
Even if you want to keep the code same for each type in serialize method for
generated code, you still have another two ways to achieve this goal:
1. call readBool in readBoolean
2. add if-else and specify readBool for boolean type in ftl.
##########
java/tsfile/src/main/java/org/apache/tsfile/read/filter/basic/ValueFilter.java:
##########
@@ -75,6 +75,24 @@ public boolean[] satisfyTsBlock(TsBlock tsBlock) {
return satisfyInfo;
}
+ @Override
+ public boolean[] satisfyTsBlock(boolean[] selection, TsBlock tsBlock) {
Review Comment:
Will this method be used in new generated fller?
##########
java/tsfile/src/main/java/org/apache/tsfile/utils/ReadWriteIOUtils.java:
##########
@@ -95,6 +95,12 @@ public static boolean readBool(ByteBuffer buffer) {
return a == 1;
}
+ /** read a bool from byteBuffer. */
+ public static boolean readBoolean(ByteBuffer buffer) {
Review Comment:
why not using existing `readBool`?
##########
java/tsfile/src/main/java/org/apache/tsfile/read/filter/basic/Filter.java:
##########
@@ -82,6 +82,14 @@ public abstract class Filter {
*/
public abstract boolean[] satisfyTsBlock(TsBlock tsBlock);
Review Comment:
do we still need this method in IoTDB? if we just to keep compatibility, we
can add @Deprecated annotation for this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
