761417898 commented on code in PR #192:
URL: https://github.com/apache/tsfile/pull/192#discussion_r1712904500
##########
cpp/src/common/tsfile_common.h:
##########
@@ -353,10 +374,10 @@ class TimeseriesIndex {
FORCE_INLINE void set_measurement_name(common::String &measurement_name) {
measurement_name_.shallow_copy_from(measurement_name);
}
- FORCE_INLINE common::String get_measurement_name() {
+ FORCE_INLINE virtual common::String get_measurement_name() {
return measurement_name_;
}
- common::SimpleList<ChunkMeta *> *get_chunk_meta_list() const {
+ virtual common::SimpleList<ChunkMeta *> *get_chunk_meta_list() const {
return chunk_meta_list_;
}
Review Comment:
Change the function to `inline`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
