luoluoyuyu commented on code in PR #284:
URL: https://github.com/apache/tsfile/pull/284#discussion_r1830338617
##########
java/tsfile/src/main/java/org/apache/tsfile/read/reader/series/FileSeriesReader.java:
##########
@@ -56,8 +56,10 @@ protected void initChunkReader(IChunkMetadata chunkMetaData)
throws IOException
chunkLoader.loadChunk((ChunkMetadata)
(alignedChunkMetadata.getTimeChunkMetadata()));
List<Chunk> valueChunkList = new ArrayList<>();
for (IChunkMetadata metadata :
alignedChunkMetadata.getValueChunkMetadataList()) {
- valueChunkList.add(chunkLoader.loadChunk((ChunkMetadata) metadata));
- currentChunkMeasurementNames.add(metadata.getMeasurementUid());
+ if (metadata != null) {
Review Comment:
I think it is unnecessary, because if Chunk is null, no subsequent read
operations can be performed, and if ChunkMeta is null or ChunkMeta count is 0,
it is saved as null in ChunkMetaList.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
