jt2594838 commented on code in PR #387:
URL: https://github.com/apache/tsfile/pull/387#discussion_r1943952449
##########
cpp/src/cwrapper/tsfile_cwrapper.h:
##########
@@ -186,56 +186,63 @@ ERRNO tsfile_writer_write_ts_record(TsFileWriter writer,
TsRecord record);
ERRNO tsfile_writer_flush_data(TsFileWriter writer);
/*-------------------TsFile reader query data------------------ */
-ResultSet tsfile_reader_query_table(TsFileReader reader, char* table_name,
- char** columns, uint32_t column_num,
+ResultSet tsfile_reader_query_table(TsFileReader reader, const char*
table_name,
+ const char** columns, uint32_t column_num,
timestamp start_time, timestamp end_time);
ResultSet tsfile_reader_query_path(TsFileReader reader, char** path_list,
uint32_t path_num, timestamp start_time,
timestamp end_time);
bool tsfile_result_set_has_next(ResultSet result_set);
-#define tsfile_result_set_get_value_by_name_(type) \
+#define TSFILE_RESULT_SET_GET_VALUE_BY_NAME(type) \
type tsfile_result_set_get_value_by_name_##type(ResultSet result_set, \
- const char* column_name)
-tsfile_result_set_get_value_by_name_(bool);
-tsfile_result_set_get_value_by_name_(int32_t);
-tsfile_result_set_get_value_by_name_(int64_t);
-tsfile_result_set_get_value_by_name_(float);
-tsfile_result_set_get_value_by_name_(double);
-
-#define tsfile_result_set_get_value_by_index_(type) \
+ const char* column_name)
+TSFILE_RESULT_SET_GET_VALUE_BY_NAME(bool);
+TSFILE_RESULT_SET_GET_VALUE_BY_NAME(int32_t);
+TSFILE_RESULT_SET_GET_VALUE_BY_NAME(int64_t);
+TSFILE_RESULT_SET_GET_VALUE_BY_NAME(float);
+TSFILE_RESULT_SET_GET_VALUE_BY_NAME(double);
+
+#define TSFILE_RESULT_SET_GET_VALUE_BY_INDEX(type) \
type tsfile_result_set_get_value_by_index_##type(ResultSet result_set, \
uint32_t column_index);
-tsfile_result_set_get_value_by_index_(int32_t);
-tsfile_result_set_get_value_by_index_(int64_t);
-tsfile_result_set_get_value_by_index_(float);
-tsfile_result_set_get_value_by_index_(double);
-tsfile_result_set_get_value_by_index_(bool);
+TSFILE_RESULT_SET_GET_VALUE_BY_INDEX(int32_t);
+TSFILE_RESULT_SET_GET_VALUE_BY_INDEX(int64_t);
+TSFILE_RESULT_SET_GET_VALUE_BY_INDEX(float);
+TSFILE_RESULT_SET_GET_VALUE_BY_INDEX(double);
+TSFILE_RESULT_SET_GET_VALUE_BY_INDEX(bool);
-bool tsfile_result_set_is_null_by_name(ResultSet result_set,
- char* column_name);
+bool tsfile_result_set_is_null_by_name(ResultSet result_set, char*
column_name);
bool tsfile_result_set_is_null_by_index(ResultSet result_set,
- uint32_t column_index);
+ uint32_t column_index);
ResultSetMetaData tsfile_result_set_get_metadata(ResultSet result_set);
+char *tsfile_result_set_meta_get_column_name(ResultSetMetaData result_set,
+ uint32_t column_index);
+TSDataType tsfile_result_set_meta_get_data_type(ResultSetMetaData result_set,
+ uint32_t column_index);
+int tsfile_result_set_meta_get_column_num(ResultSetMetaData result_set);
-
-// Desc Table Schema
-
+// Desc table schema.
TableSchema tsfile_reader_get_table_schema(TsFileReader reader,
const char* table_name);
-DeviceSchema tsfile_reader_get_timeseries_schema(TsFileReader reader, const
char* device_id);
-
-// destroy pointer
-ERRNO destroy_tsfile_ts_record(TsRecord record);
-ERRNO destroy_tablet(Tablet tablet);
-void destroy_tsfile_result_set(ResultSet result_set);
-void destroy_device_schema(DeviceSchema schema);
-void destroy_timeseries_schema(TimeseriesSchema schema);
-void destroy_table_schema(TableSchema schema);
-void destroy_column_schema(ColumnSchema schema);
+DeviceSchema tsfile_reader_get_timeseries_schema(TsFileReader reader,
+ const char* device_id);
Review Comment:
get_timeseries_schema -> get_device_schema
##########
cpp/src/cwrapper/tsfile_cwrapper.cc:
##########
@@ -244,9 +246,7 @@ ERRNO tsfile_writer_write_ts_record(TsFileWriter writer,
TsRecord data) {
auto *w = static_cast<storage::TsFileWriter *>(writer);
const auto *record = static_cast<storage::TsRecord *>(data);
const int ret = w->write_record(*record);
- if (ret == common::E_OK) {
- delete record;
- }
+ delete record;
return ret;
Review Comment:
Is it necessary to delete `record` here? The caller may wish to reuse it for
multiple insertions.
If it is, please add some comments to the declaration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
