zwhzzz0821 commented on code in PR #409:
URL: https://github.com/apache/tsfile/pull/409#discussion_r1962835689
##########
cpp/src/common/allocator/my_string.h:
##########
@@ -35,6 +35,13 @@ struct String {
String() : buf_(nullptr), len_(0) {}
String(char *buf, uint32_t len) : buf_(buf), len_(len) {}
+ String(const std::string& str, common::PageArena& pa) : buf_(nullptr),
len_(0) {
+ dup_from(str, pa);
+ }
+ String(const std::string& str) {
+ buf_ = (char*)str.c_str();
+ len_ = str.size();
+ }
Review Comment:
SingleDeviceTsBlockReader::fill_ids().
I think we need a temporary String object to write to. So I added this
constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
