jt2594838 commented on code in PR #433:
URL: https://github.com/apache/tsfile/pull/433#discussion_r1986688768
##########
cpp/src/reader/block/device_ordered_tsblock_reader.cc:
##########
@@ -43,15 +43,23 @@ int DeviceOrderedTsBlockReader::has_next(bool &has_next) {
task, block_size_, metadata_querier_, tsfile_io_reader_,
time_filter_,
field_filter_);
if (current_reader_ == nullptr) {
- has_next = false;
return common::E_OOM;
}
+
if (RET_FAIL(current_reader_->has_next(has_next))) {
return ret;
- } else {
- return common::E_OK;
+ }
+ // If current device do not have data, get next device.
+ if (has_next) {
+ return ret;
+ }
Review Comment:
The comment and the condition conflict, double-check.
##########
python/tsfile/tsfile_py_cpp.pyx:
##########
@@ -370,6 +387,8 @@ cdef ResultSet tsfile_reader_query_table_c(TsFileReader
reader, object table_nam
columns[i] = strdup((<str>column_list[i]).encode('utf-8'))
if columns[i] == NULL:
raise MemoryError("Failed to allocate memory for column name")
+ print("begin to query table:" + table_name + "start_time:" +
str(start_time)
+ +"end_time:" + str(end_time))
Review Comment:
Remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
