761417898 commented on code in PR #542: URL: https://github.com/apache/tsfile/pull/542#discussion_r2209420265
########## cpp/test/encoding/int32_packer_test.cc: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * License); you may not use this file except in compliance + * with the License. You may obtain a copy of the License a + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#include "encoding/int32_packer.h" + +#include <gtest/gtest.h> + +#include <bitset> + +namespace storage { + +TEST(IntPackerTest, SequentialValues) { + for (int width = 4; width < 32; ++width) { + int32_t arr[8]; + for (int i = 0; i < 8; ++i) arr[i] = i; + Int32Packer packer(width); + const int bufSize = NUM_OF_INTS * width / 8; + std::vector<unsigned char> buf(bufSize, 0); + packer.pack_8values(arr, 0, buf.data()); + int32_t res[8] = {0}; + packer.unpack_8values(buf.data(), 0, res); + for (int i = 0; i < 8; ++i) { + EXPECT_EQ(res[i], arr[i]) << "Width=" << width << " Index=" << i; + } + } +} + +TEST(IntPackerStressTest, PackUnpackRandomPositiveValues) { + const int width = 31; + const int count = 100000; + const int total_values = count * 8; + + Int32Packer packer(width); + std::vector<int32_t> pre_values; + std::vector<unsigned char> buffer; + pre_values.reserve(total_values); + buffer.resize(count * width); + int idx = 0; + std::srand(12345); // Optional: deterministic seed + for (int i = 0; i < count; ++i) { + int32_t vs[8]; + for (int j = 0; j < 8; ++j) { + vs[j] = std::rand() & + 0x7FFFFFFF; // ensure non-negative (Java `nextInt`) + pre_values.push_back(vs[j]); + } + + unsigned char temp_buf[32] = {0}; + packer.pack_8values(vs, 0, temp_buf); + std::memcpy(buffer.data() + idx, temp_buf, width); + idx += width; + } + + std::vector<int32_t> res(total_values); + packer.unpack_all_values(buffer.data(), static_cast<int>(buffer.size()), + res.data()); + for (int i = 0; i < total_values; ++i) { + ASSERT_EQ(res[i], pre_values[i]) << "Mismatch at index " << i; Review Comment: ``` for (int i = 0; i < total_values; ++i) { if (res[i] != pre_values[i]) { diff_msg += "\nMismatch at index " + std::to_string(i) + ": expected=" + std::to_string(pre_values[i]) + ", actual=" + std::to_string(res[i]); } } ASSERT_TRUE(diff_msg.empty()) << diff_msg; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@tsfile.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
