hongzhi-gao commented on code in PR #648: URL: https://github.com/apache/tsfile/pull/648#discussion_r2576291482
########## cpp/src/common/device_id.cc: ########## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * License); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "common/device_id.h" + +#include <algorithm> +#include <cctype> +#include <numeric> +#include <stdexcept> +#include <unordered_set> + +#include "constant/tsfile_constant.h" +#ifdef ENABLE_ANTLR4 +#include "parser/path_nodes_generator.h" +#endif +#include "utils/errno_define.h" + +namespace storage { + +// IDeviceID implementation +IDeviceID::IDeviceID() : empty_segments_() {} + +int IDeviceID::serialize(common::ByteStream& write_stream) { return 0; } +int IDeviceID::deserialize(common::ByteStream& read_stream) { return 0; } +std::string IDeviceID::get_table_name() { return ""; } +int IDeviceID::segment_num() { return 0; } +const std::vector<std::string*>& IDeviceID::get_segments() const { + return empty_segments_; +} +std::string IDeviceID::get_device_name() const { return ""; } +bool IDeviceID::operator<(const IDeviceID& other) { return false; } +bool IDeviceID::operator==(const IDeviceID& other) { return false; } +bool IDeviceID::operator!=(const IDeviceID& other) { return false; } + +// IDeviceIDComparator implementation +bool IDeviceIDComparator::operator()( + const std::shared_ptr<IDeviceID>& lhs, + const std::shared_ptr<IDeviceID>& rhs) const { + return *lhs < *rhs; +} + +// StringArrayDeviceID implementation +StringArrayDeviceID::StringArrayDeviceID( + const std::vector<std::string>& segments) + : segments_(formalize(segments)) {} + +StringArrayDeviceID::StringArrayDeviceID(const std::string& device_id_string) { + auto segments = split_device_id_string(device_id_string); + segments_.reserve(segments.size()); + for (const auto& segment : segments) { + segments_.push_back(new std::string(segment)); + } +} + +StringArrayDeviceID::StringArrayDeviceID( + const std::vector<std::string*>& segments) { + segments_.reserve(segments.size()); + for (const auto& segment : segments) { + segments_.push_back(segment == nullptr ? nullptr + : new std::string(*segment)); + } +} + +StringArrayDeviceID::StringArrayDeviceID() : segments_() {} + +StringArrayDeviceID::~StringArrayDeviceID() { + for (const auto& segment : segments_) { + delete segment; + } +} + +std::string StringArrayDeviceID::get_device_name() const { + if (segments_.empty()) { + return ""; + } + + std::string result(*segments_.front()); + for (auto it = std::next(segments_.begin()); it != segments_.end(); ++it) { + result += '.'; + if (*it != nullptr) { + result += **it; + } else { + result += "null"; + } + } + + return result; +} + +int StringArrayDeviceID::serialize(common::ByteStream& write_stream) { + int ret = common::E_OK; + if (RET_FAIL(common::SerializationUtil::write_var_uint(segment_num(), + write_stream))) { + return ret; + } + for (const auto& segment : segments_) { + if (RET_FAIL(common::SerializationUtil::write_var_char_ptr( + segment, write_stream))) { + return ret; + } + } + return ret; +} + +int StringArrayDeviceID::deserialize(common::ByteStream& read_stream) { + int ret = common::E_OK; + uint32_t num_segments; + if (RET_FAIL(common::SerializationUtil::read_var_uint(num_segments, + read_stream))) { + return ret; + } + + for (auto& segment : segments_) { + if (segment != nullptr) { + delete segment; + } + } + + segments_.clear(); + for (uint32_t i = 0; i < num_segments; ++i) { + std::string* segment; + if (RET_FAIL(common::SerializationUtil::read_var_char_ptr( + segment, read_stream))) { + delete segment; + return ret; + } + segments_.push_back(segment); + } + return ret; +} + +std::string StringArrayDeviceID::get_table_name() { + return segments_.empty() ? "" : *segments_[0]; +} + +int StringArrayDeviceID::segment_num() { + return static_cast<int>(segments_.size()); +} + +const std::vector<std::string*>& StringArrayDeviceID::get_segments() const { + return segments_; +} + +bool StringArrayDeviceID::operator<(const IDeviceID& other) { + auto other_segments = other.get_segments(); + return std::lexicographical_compare( + segments_.begin(), segments_.end(), other_segments.begin(), + other_segments.end(), [](const std::string* a, const std::string* b) { + if (a == nullptr && b == nullptr) return false; // equal + if (a == nullptr) return true; // nullptr < any string + if (b == nullptr) return false; // any string > nullptr + return *a < *b; + }); +} + +bool StringArrayDeviceID::operator==(const IDeviceID& other) { + auto other_segments = other.get_segments(); + return (segments_.size() == other_segments.size()) && + std::equal(segments_.begin(), segments_.end(), + other_segments.begin(), + [](const std::string* a, const std::string* b) { + if (a == nullptr && b == nullptr) return true; + if (a == nullptr || b == nullptr) return false; + return *a == *b; + }); +} + +bool StringArrayDeviceID::operator!=(const IDeviceID& other) { + return !(*this == other); +} + +std::vector<std::string*> StringArrayDeviceID::formalize( + const std::vector<std::string>& segments) { + auto it = std::find_if(segments.rbegin(), segments.rend(), + [](const std::string& seg) { return !seg.empty(); }); + std::vector<std::string> validate_segments(segments.begin(), it.base()); + std::vector<std::string*> result; + result.reserve(validate_segments.size()); + for (const auto& segment : validate_segments) { + result.emplace_back(new std::string(segment)); + } + return result; +} + Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
