jt2594838 commented on code in PR #676:
URL: https://github.com/apache/tsfile/pull/676#discussion_r2646731219
##########
java/tsfile/src/main/java/org/apache/tsfile/read/common/block/column/BooleanColumn.java:
##########
@@ -93,11 +95,26 @@ public boolean getBoolean(int position) {
return values[position + arrayOffset];
}
+ @Override
+ public Binary getBinary(int position) {
+ Binary[] binaries = getBinaries();
+ return binaries.length > 0 ? binaries[position + arrayOffset] : null;
+ }
+
Review Comment:
Not necessary to copy the whole array just because accessing a single value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
