jt2594838 commented on code in PR #739:
URL: https://github.com/apache/tsfile/pull/739#discussion_r2963776070
##########
cpp/src/common/tablet.cc:
##########
@@ -163,6 +163,89 @@ int Tablet::add_timestamp(uint32_t row_index, int64_t
timestamp) {
return E_OK;
}
+int Tablet::set_timestamps(const int64_t* timestamps, uint32_t count) {
+ if (err_code_ != E_OK) {
+ return err_code_;
+ }
+ ASSERT(timestamps_ != NULL);
+ if (UNLIKELY(count > static_cast<uint32_t>(max_row_num_))) {
+ return E_OUT_OF_RANGE;
+ }
+ std::memcpy(timestamps_, timestamps, count * sizeof(int64_t));
+ cur_row_size_ = std::max(count, cur_row_size_);
+ return E_OK;
+}
+
+int Tablet::set_column_values(uint32_t schema_index, const void* data,
+ const uint8_t* null_bitmap, uint32_t count) {
Review Comment:
Yes, that is my intention.
Using two sets of interfaces at the same time is a great burden to
understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
