Author: fmancinelli
Date: 2007-11-01 22:42:21 +0100 (Thu, 01 Nov 2007)
New Revision: 5601
Added:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/IXWikiEclipseEventListener.java
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/XWikiEclipseEvent.java
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/XWikiEclipseNotificationCenter.java
Removed:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/IXWikiConnectionManagerListener.java
Modified:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/XWikiConnectionManager.java
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/IXWikiConnection.java
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/impl/AbstractXWikiConnection.java
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/impl/XWikiCachedConnection.java
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/impl/XWikiPlainConnection.java
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/views/XWikiExplorerView.java
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/views/XWikiPagePreviewView.java
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/wizards/NewConnectionWizard.java
Log:
XECLIPSE-30
* Refactored the publish-subscribe mechanism. Now there is a
XWikiEclipseNotificationCenter that is the main hub for all the notification of
XEclipse related events
Deleted:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/IXWikiConnectionManagerListener.java
===================================================================
---
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/IXWikiConnectionManagerListener.java
2007-11-01 19:11:26 UTC (rev 5600)
+++
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/IXWikiConnectionManagerListener.java
2007-11-01 21:42:21 UTC (rev 5601)
@@ -1,31 +0,0 @@
-/*
- * See the NOTICE file distributed with this work for additional
- * information regarding copyright ownership.
- *
- * This is free software; you can redistribute it and/or modify it
- * under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation; either version 2.1 of
- * the License, or (at your option) any later version.
- *
- * This software is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this software; if not, write to the Free
- * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
- * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
- *
- */
-package org.xwiki.xeclipse;
-
-import org.xwiki.xeclipse.model.IXWikiConnection;
-
-public interface IXWikiConnectionManagerListener
-{
- void connectionAdded(IXWikiConnection xwikiConnection);
-
- void connectionRemoved(IXWikiConnection xwikiConnection);
-
-}
Added:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/IXWikiEclipseEventListener.java
===================================================================
---
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/IXWikiEclipseEventListener.java
(rev 0)
+++
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/IXWikiEclipseEventListener.java
2007-11-01 21:42:21 UTC (rev 5601)
@@ -0,0 +1,6 @@
+package org.xwiki.xeclipse;
+
+public interface IXWikiEclipseEventListener
+{
+ public void handleEvent(Object sender, XWikiEclipseEvent event, Object
data);
+}
Modified:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/XWikiConnectionManager.java
===================================================================
---
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/XWikiConnectionManager.java
2007-11-01 19:11:26 UTC (rev 5600)
+++
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/XWikiConnectionManager.java
2007-11-01 21:42:21 UTC (rev 5601)
@@ -30,7 +30,6 @@
import java.util.List;
import java.util.Map;
-import org.eclipse.core.runtime.ListenerList;
import org.xwiki.xeclipse.model.IXWikiConnection;
import org.xwiki.xeclipse.model.XWikiConnectionException;
@@ -40,9 +39,7 @@
private List<IXWikiConnection> xwikiConnections;
private Map<String, String> idToPasswordMapping;
-
- private ListenerList connectionManagerListenerList;
-
+
public static XWikiConnectionManager getDefault()
{
if (sharedInstance == null) {
@@ -55,8 +52,7 @@
private XWikiConnectionManager()
{
xwikiConnections = new ArrayList<IXWikiConnection>();
- idToPasswordMapping = new HashMap<String, String>();
- connectionManagerListenerList = new ListenerList();
+ idToPasswordMapping = new HashMap<String, String>();
}
public List<IXWikiConnection> getConnections()
@@ -69,14 +65,15 @@
if (!xwikiConnections.contains(xwikiConnection)) {
xwikiConnections.add(xwikiConnection);
idToPasswordMapping.put(xwikiConnection.getId(), password);
- fireConnectionAdded(xwikiConnection);
+
+ XWikiEclipseNotificationCenter.getDefault().fireEvent(this,
XWikiEclipseEvent.CONNECTION_ADDED, xwikiConnection);
}
}
public void removeConnection(IXWikiConnection xwikiConnection)
{
- xwikiConnections.remove(xwikiConnection);
- fireConnectionRemoved(xwikiConnection);
+ xwikiConnections.remove(xwikiConnection);
+ XWikiEclipseNotificationCenter.getDefault().fireEvent(this,
XWikiEclipseEvent.CONNECTION_REMOVED, xwikiConnection);
}
public String getPasswordForConnection(String id) {
@@ -109,46 +106,5 @@
e.printStackTrace();
}
}
- }
-
- // /////////////////////////// Event listeners management
/////////////////////////////
-
- public void addConnectionManagerListener(IXWikiConnectionManagerListener
listener)
- {
- connectionManagerListenerList.add(listener);
- }
-
- public void
removeConnectionManagerListener(IXWikiConnectionManagerListener listener)
- {
- connectionManagerListenerList.remove(listener);
- }
-
- protected void fireConnectionAdded(final IXWikiConnection xwikiConnection)
- {
- if (xwikiConnection == null) {
- throw new NullPointerException();
- }
-
- final Object[] listeners =
connectionManagerListenerList.getListeners();
- for (int i = 0; i < listeners.length; i++) {
- final IXWikiConnectionManagerListener listener =
- (IXWikiConnectionManagerListener) listeners[i];
- listener.connectionAdded(xwikiConnection);
- }
- }
-
- protected void fireConnectionRemoved(final IXWikiConnection
xwikiConnection)
- {
- if (xwikiConnection == null) {
- throw new NullPointerException();
- }
-
- final Object[] listeners =
connectionManagerListenerList.getListeners();
- for (int i = 0; i < listeners.length; i++) {
- final IXWikiConnectionManagerListener listener =
- (IXWikiConnectionManagerListener) listeners[i];
- listener.connectionRemoved(xwikiConnection);
- }
- }
-
+ }
}
Added:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/XWikiEclipseEvent.java
===================================================================
---
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/XWikiEclipseEvent.java
(rev 0)
+++
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/XWikiEclipseEvent.java
2007-11-01 21:42:21 UTC (rev 5601)
@@ -0,0 +1,13 @@
+package org.xwiki.xeclipse;
+
+public enum XWikiEclipseEvent
+{
+ /* Sender: XWikiConnectionManager, Data: IXWikiConnection */
+ CONNECTION_ADDED,
+ /* Sender: XWikiConnectionManager, Data: IXWikiConnection */
+ CONNECTION_REMOVED,
+ /* Sender: IXWikiConnection, Data: null */
+ CONNECTION_ESTABLISHED,
+ /* Sender: IXWikiConnection, Data: null */
+ CONNECTION_CLOSED
+}
Added:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/XWikiEclipseNotificationCenter.java
===================================================================
---
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/XWikiEclipseNotificationCenter.java
(rev 0)
+++
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/XWikiEclipseNotificationCenter.java
2007-11-01 21:42:21 UTC (rev 5601)
@@ -0,0 +1,53 @@
+package org.xwiki.xeclipse;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.eclipse.core.runtime.ListenerList;
+
+public class XWikiEclipseNotificationCenter
+{
+ private Map<XWikiEclipseEvent, ListenerList> eventyTypeToListenersMapping;
+ private static XWikiEclipseNotificationCenter instance;
+
+ private XWikiEclipseNotificationCenter()
+ {
+ eventyTypeToListenersMapping = new HashMap<XWikiEclipseEvent,
ListenerList>();
+ }
+
+ public static XWikiEclipseNotificationCenter getDefault() {
+ if(instance == null) {
+ instance = new XWikiEclipseNotificationCenter();
+ }
+
+ return instance;
+ }
+
+ public void addListener(XWikiEclipseEvent eventType, Object listener)
+ {
+ ListenerList listenerList =
eventyTypeToListenersMapping.get(eventType);
+ if(listenerList == null) {
+ listenerList = new ListenerList();
+ eventyTypeToListenersMapping.put(eventType, listenerList);
+ }
+
+ listenerList.add(listener);
+ }
+
+ public void removeListener(XWikiEclipseEvent eventType,
IXWikiEclipseEventListener listener) {
+ ListenerList listenerList =
eventyTypeToListenersMapping.get(eventType);
+ if(listenerList != null) {
+ listenerList.remove(listener);
+ }
+ }
+
+ public void fireEvent(Object sender, XWikiEclipseEvent eventType, Object
data) {
+ ListenerList listenerList =
eventyTypeToListenersMapping.get(eventType);
+ if(listenerList != null) {
+ Object[] listeners = listenerList.getListeners();
+ for (int i = 0; i < listeners.length; ++i) {
+ ((IXWikiEclipseEventListener) listeners[i]).handleEvent(sender,
eventType, data);
+ }
+ }
+ }
+}
Modified:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/IXWikiConnection.java
===================================================================
---
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/IXWikiConnection.java
2007-11-01 19:11:26 UTC (rev 5600)
+++
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/IXWikiConnection.java
2007-11-01 21:42:21 UTC (rev 5601)
@@ -82,7 +82,4 @@
public String getUserName();
public String getServerUrl();
-
- public void addConnectionEstablishedListener(IXWikiConnectionListener
listener);
- public void removeConnectionEstablishedListener(IXWikiConnectionListener
listener);
}
Modified:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/impl/AbstractXWikiConnection.java
===================================================================
---
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/impl/AbstractXWikiConnection.java
2007-11-01 19:11:26 UTC (rev 5600)
+++
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/impl/AbstractXWikiConnection.java
2007-11-01 21:42:21 UTC (rev 5601)
@@ -25,8 +25,6 @@
protected transient boolean isDisposed;
- private transient ListenerList connectionListenerList;
-
/**
* Constructor.
*
@@ -48,8 +46,7 @@
*/
protected void init() throws XWikiConnectionException
{
- isDisposed = false;
- connectionListenerList = new ListenerList();
+ isDisposed = false;
}
/**
@@ -93,34 +90,4 @@
abstract Page getRawPage(String pageId) throws XWikiConnectionException;
abstract Space getRawSpace(String key);
-
- // /////////////////////////// Event listeners management
/////////////////////////////
-
- public void addConnectionEstablishedListener(IXWikiConnectionListener
listener)
- {
- connectionListenerList.add(listener);
- }
-
- public void removeConnectionEstablishedListener(IXWikiConnectionListener
listener)
- {
- connectionListenerList.remove(listener);
- }
-
- protected void fireConnectionEstablished()
- {
- final Object[] listeners = connectionListenerList.getListeners();
- for (int i = 0; i < listeners.length; i++) {
- final IXWikiConnectionListener listener =
(IXWikiConnectionListener) listeners[i];
- listener.connectionEstablished(this);
- }
- }
-
- protected void fireConnectionClosed()
- {
- final Object[] listeners = connectionListenerList.getListeners();
- for (int i = 0; i < listeners.length; i++) {
- final IXWikiConnectionListener listener =
(IXWikiConnectionListener) listeners[i];
- listener.connectionClosed(this);
- }
- }
}
Modified:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/impl/XWikiCachedConnection.java
===================================================================
---
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/impl/XWikiCachedConnection.java
2007-11-01 19:11:26 UTC (rev 5600)
+++
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/impl/XWikiCachedConnection.java
2007-11-01 21:42:21 UTC (rev 5601)
@@ -13,6 +13,8 @@
import org.codehaus.swizzle.confluence.PageSummary;
import org.codehaus.swizzle.confluence.Space;
import org.codehaus.swizzle.confluence.SpaceSummary;
+import org.xwiki.xeclipse.XWikiEclipseEvent;
+import org.xwiki.xeclipse.XWikiEclipseNotificationCenter;
import org.xwiki.xeclipse.model.IXWikiPage;
import org.xwiki.xeclipse.model.IXWikiSpace;
import org.xwiki.xeclipse.model.XWikiConnectionException;
@@ -214,7 +216,7 @@
throw new XWikiConnectionException(e);
}
- fireConnectionEstablished();
+ XWikiEclipseNotificationCenter.getDefault().fireEvent(this,
XWikiEclipseEvent.CONNECTION_ESTABLISHED, null);
}
/**
@@ -237,7 +239,7 @@
e.printStackTrace();
}
- fireConnectionClosed();
+ XWikiEclipseNotificationCenter.getDefault().fireEvent(this,
XWikiEclipseEvent.CONNECTION_CLOSED, null);
}
/**
Modified:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/impl/XWikiPlainConnection.java
===================================================================
---
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/impl/XWikiPlainConnection.java
2007-11-01 19:11:26 UTC (rev 5600)
+++
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/model/impl/XWikiPlainConnection.java
2007-11-01 21:42:21 UTC (rev 5601)
@@ -10,6 +10,8 @@
import org.codehaus.swizzle.confluence.Space;
import org.codehaus.swizzle.confluence.SpaceSummary;
import org.eclipse.core.runtime.ListenerList;
+import org.xwiki.xeclipse.XWikiEclipseEvent;
+import org.xwiki.xeclipse.XWikiEclipseNotificationCenter;
import org.xwiki.xeclipse.model.IXWikiConnectionListener;
import org.xwiki.xeclipse.model.IXWikiPage;
import org.xwiki.xeclipse.model.IXWikiSpace;
@@ -61,7 +63,7 @@
throw new XWikiConnectionException(e);
}
- fireConnectionEstablished();
+ XWikiEclipseNotificationCenter.getDefault().fireEvent(this,
XWikiEclipseEvent.CONNECTION_ESTABLISHED, null);
}
/**
@@ -84,7 +86,7 @@
e.printStackTrace();
}
- fireConnectionClosed();
+ XWikiEclipseNotificationCenter.getDefault().fireEvent(this,
XWikiEclipseEvent.CONNECTION_CLOSED, null);
}
/**
Modified:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/views/XWikiExplorerView.java
===================================================================
---
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/views/XWikiExplorerView.java
2007-11-01 19:11:26 UTC (rev 5600)
+++
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/views/XWikiExplorerView.java
2007-11-01 21:42:21 UTC (rev 5601)
@@ -43,21 +43,21 @@
import org.eclipse.ui.menus.CommandContributionItem;
import org.eclipse.ui.model.WorkbenchLabelProvider;
import org.eclipse.ui.part.ViewPart;
-import org.xwiki.xeclipse.IXWikiConnectionManagerListener;
+import org.xwiki.xeclipse.IXWikiEclipseEventListener;
import org.xwiki.xeclipse.XWikiConnectionManager;
import org.xwiki.xeclipse.XWikiEclipseConstants;
+import org.xwiki.xeclipse.XWikiEclipseEvent;
+import org.xwiki.xeclipse.XWikiEclipseNotificationCenter;
import org.xwiki.xeclipse.editors.XWikiPageEditor;
import org.xwiki.xeclipse.editors.XWikiPageEditorInput;
import org.xwiki.xeclipse.handlers.ConnectHandler;
import org.xwiki.xeclipse.handlers.DisconnectHandler;
import org.xwiki.xeclipse.handlers.RemoveConnectionHandler;
import org.xwiki.xeclipse.model.IXWikiConnection;
-import org.xwiki.xeclipse.model.IXWikiConnectionListener;
import org.xwiki.xeclipse.model.IXWikiPage;
import org.xwiki.xeclipse.utils.XWikiEclipseUtil;
-public class XWikiExplorerView extends ViewPart implements
IXWikiConnectionManagerListener,
- IXWikiConnectionListener
+public class XWikiExplorerView extends ViewPart implements
IXWikiEclipseEventListener
{
public static final String ID = "org.xwiki.xeclipse.views.XWikiExplorer";
@@ -169,29 +169,21 @@
{
super.init(site);
activateHandlers(site);
- XWikiConnectionManager.getDefault().addConnectionManagerListener(this);
-
- /* Monitors the connections that are already registered in the
connection manager */
- for (IXWikiConnection xwikiConnection :
XWikiConnectionManager.getDefault()
- .getConnections()) {
- xwikiConnection.addConnectionEstablishedListener(this);
- }
+
+
XWikiEclipseNotificationCenter.getDefault().addListener(XWikiEclipseEvent.CONNECTION_ADDED,
this);
+
XWikiEclipseNotificationCenter.getDefault().addListener(XWikiEclipseEvent.CONNECTION_REMOVED,
this);
+
XWikiEclipseNotificationCenter.getDefault().addListener(XWikiEclipseEvent.CONNECTION_ESTABLISHED,
this);
+
XWikiEclipseNotificationCenter.getDefault().addListener(XWikiEclipseEvent.CONNECTION_CLOSED,
this);
}
@Override
public void dispose()
- {
- /*
- * Removes the connection listening on all connections still
registered in the connection
- * manager
- */
- for (IXWikiConnection xwikiConnection :
XWikiConnectionManager.getDefault()
- .getConnections()) {
- xwikiConnection.removeConnectionEstablishedListener(this);
- }
+ {
+
XWikiEclipseNotificationCenter.getDefault().removeListener(XWikiEclipseEvent.CONNECTION_ADDED,
this);
+
XWikiEclipseNotificationCenter.getDefault().removeListener(XWikiEclipseEvent.CONNECTION_REMOVED,
this);
+
XWikiEclipseNotificationCenter.getDefault().removeListener(XWikiEclipseEvent.CONNECTION_ESTABLISHED,
this);
+
XWikiEclipseNotificationCenter.getDefault().removeListener(XWikiEclipseEvent.CONNECTION_CLOSED,
this);
-
XWikiConnectionManager.getDefault().removeConnectionManagerListener(this);
-
super.dispose();
}
@@ -283,26 +275,21 @@
});
}
- public void connectionAdded(IXWikiConnection xwikiConnection)
+ public void handleEvent(Object sender, XWikiEclipseEvent event, Object
data)
{
- xwikiConnection.addConnectionEstablishedListener(this);
- treeViewer.refresh();
+ switch(event) {
+ case CONNECTION_ADDED:
+ case CONNECTION_REMOVED:
+ treeViewer.refresh();
+ break;
+ case CONNECTION_ESTABLISHED:
+ case CONNECTION_CLOSED:
+
if(XWikiConnectionManager.getDefault().getConnections().contains(sender)) {
+ treeViewer.refresh(sender);
+ }
+ break;
+ }
+
}
- public void connectionRemoved(IXWikiConnection xwikiConnection)
- {
- xwikiConnection.removeConnectionEstablishedListener(this);
- treeViewer.refresh();
- }
-
- public void connectionEstablished(IXWikiConnection connection)
- {
- treeViewer.refresh(connection);
- }
-
- public void connectionClosed(IXWikiConnection connection)
- {
- treeViewer.refresh(connection);
- }
-
}
Modified:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/views/XWikiPagePreviewView.java
===================================================================
---
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/views/XWikiPagePreviewView.java
2007-11-01 19:11:26 UTC (rev 5600)
+++
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/views/XWikiPagePreviewView.java
2007-11-01 21:42:21 UTC (rev 5601)
@@ -74,7 +74,7 @@
}
public void selectionChanged(IWorkbenchPart part, ISelection selection)
- {
+ {
Object selectedObject =
XWikiEclipseUtil.getSingleSelectedObjectInStructuredSelection(selection);
if(selectedObject instanceof IXWikiPage) {
IXWikiPage xwikiPage = (IXWikiPage) selectedObject;
Modified:
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/wizards/NewConnectionWizard.java
===================================================================
---
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/wizards/NewConnectionWizard.java
2007-11-01 19:11:26 UTC (rev 5600)
+++
xwiki-extensions/xwiki-eclipse/trunk/plugins/org.xwiki.eclipse/src/main/java/org/xwiki/xeclipse/wizards/NewConnectionWizard.java
2007-11-01 21:42:21 UTC (rev 5601)
@@ -65,6 +65,7 @@
connection.dispose();
monitor.done();
} catch (Exception e) {
+ e.printStackTrace();
throw new InvocationTargetException(e);
}
}
_______________________________________________
notifications mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/notifications
