[ 
http://jira.xwiki.org/jira/browse/XWIKI-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_19726
 ] 

Thomas Mortagne commented on XWIKI-1862:
----------------------------------------

Evelina there is problems in your patch, I can't apply : you did not make it 
from updated svn it seems.

I could have corrected this but when I'm looking I see problems in you velocity 
code : for example you replace

var chbx1 = new MSCheckbox(document.getElementById('tdview'), "view", 
"${saveUrl}", "${r1}"); 

by

var chbx1 = new MSCheckbox(document.getElementById('tdview'), "view", saveUrl, 
"${r1}");

so you have saveUrl with no $

> Rights Manager Interface fixed css and xhtml validation
> -------------------------------------------------------
>
>                 Key: XWIKI-1862
>                 URL: http://jira.xwiki.org/jira/browse/XWIKI-1862
>             Project: XWiki Platform
>          Issue Type: Improvement
>          Components: Templates, Skins & User Interface
>    Affects Versions: 1.1.2, 1.2 M2
>            Reporter: Evelina Petronela Slatineanu
>         Assigned To: Evelina Petronela Slatineanu
>            Priority: Minor
>         Attachments: rights-manager-patch-16-11-2007.tar.gz
>
>
> The css and xhtml had some problems that prevented the validation:
> - unescaped "&" entities
> - the css used for the lightbox contained invalid css hacks 
> Fixes:
> - escaped "&"
> - wrote 2 separate css sheets for ie and other browsers, deleted the hacks 
> for transparent background in lightbox by using a png back image (for 
> browsers supporting png alpha transparency); for ie there is no other way 
> that to use "filter" and "opacity" hacks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.xwiki.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
notifications mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/notifications

Reply via email to