[xwiki-notifications] r6443 - xwiki-platform/xwiki-plugins/trunk/wiki-manager/src/main/java/com/xpn/xwiki/plugin/wikimanager

[SVN]

Author: tmortagne
Date: 2007-12-20 14:34:23 +0100 (Thu, 20 Dec 2007)
New Revision: 6443

Modified:
   
xwiki-platform/xwiki-plugins/trunk/wiki-manager/src/main/java/com/xpn/xwiki/plugin/wikimanager/WikiManager.java
Log:
Improve codestyle/javadoc.

Modified: 
xwiki-platform/xwiki-plugins/trunk/wiki-manager/src/main/java/com/xpn/xwiki/plugin/wikimanager/WikiManager.java
===================================================================
--- 
xwiki-platform/xwiki-plugins/trunk/wiki-manager/src/main/java/com/xpn/xwiki/plugin/wikimanager/WikiManager.java
     2007-12-20 13:32:42 UTC (rev 6442)
+++ 
xwiki-platform/xwiki-plugins/trunk/wiki-manager/src/main/java/com/xpn/xwiki/plugin/wikimanager/WikiManager.java
     2007-12-20 13:34:23 UTC (rev 6443)
@@ -39,6 +39,7 @@
 import com.xpn.xwiki.doc.XWikiDocument;
 
 import java.io.IOException;
+import java.text.MessageFormat;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Iterator;
@@ -60,21 +61,6 @@
     public static final String MESSAGETOOL_CONTEXT_KEY = 
"wikimanagermessagetool";
 
     /**
-     * Quote string.
-     */
-    public static final String QUOTE = "\"";
-
-    /**
-     * Open bracket.
-     */
-    public static final String OPEN_BRACKET = "(";
-
-    /**
-     * Close bracket.
-     */
-    public static final String CLOSE_BRACKET = ")";
-
-    /**
      * The logging tool.
      */
     protected static final Log LOG = LogFactory.getLog(WikiManager.class);
@@ -358,15 +344,15 @@
             context.setDatabase(targetWiki);
 
             Collection[] docsNames = getDocsNames(sourceWiki, context);
-            
+
             // Replace documents contents to include
             Collection docsNameToInclude = docsNames[0];
             for (Iterator it = docsNameToInclude.iterator(); it.hasNext();) {
                 String docFullName = (String) it.next();
                 XWikiDocument targetDoc = xwiki.getDocument(docFullName, 
context);
 
-                targetDoc.setContent("#includeInContext" + OPEN_BRACKET + 
QUOTE + sourceWiki
-                    + SuperDocument.WIKI_SPACE_SEPARATOR + docFullName + QUOTE 
+ CLOSE_BRACKET);
+                
targetDoc.setContent(MessageFormat.format("#includeInContext(\"{0}{1}{2}\")",
+                    new Object[] {sourceWiki, 
SuperDocument.WIKI_SPACE_SEPARATOR, docFullName}));
             }
 
             // Replace documents contents to link
@@ -375,8 +361,8 @@
                 String docFullName = (String) it.next();
                 XWikiDocument targetDoc = xwiki.getDocument(docFullName, 
context);
 
-                targetDoc.setContent("#includeTopic" + OPEN_BRACKET + QUOTE + 
sourceWiki
-                    + SuperDocument.WIKI_SPACE_SEPARATOR + docFullName + QUOTE 
+ CLOSE_BRACKET);
+                
targetDoc.setContent(MessageFormat.format("#includeTopic(\"{0}{1}{2}\")",
+                    new Object[] {sourceWiki, 
SuperDocument.WIKI_SPACE_SEPARATOR, docFullName}));
             }
         } finally {
             context.setDatabase(database);

_______________________________________________
notifications mailing list
notifications@xwiki.org
http://lists.xwiki.org/mailman/listinfo/notifications