[
http://jira.xwiki.org/jira/browse/XWIKI-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_22235
]
Vincent Massol commented on XWIKI-950:
--------------------------------------
{quote}
Guys, I'm not criticizing you but, please refactor com.xpn.xwiki.XWiki class -
it has over 6k lines of code
{quote}
Actually we're all criticizing this. I don't know a single person inside the
XWiki team not criticizing it. However I've bee trying to refactor it for about
a year now by introducing component based programming which will spread the API
in various components. But this has been slow going since we're not enough
developers/contributors and XWiki needs to progress at the same time (fix bugs,
introduce new wanted features, etc). If I could just spend 6 months purely
working on that new architecture I'm pretty sure I would be able to refactor
the whole thing but right now I don't think there's anyone to take care of the
day to day run of the platform/products if I do this...
That said, we've made lots of progress in the past years in componentizing
xwiki in general and we're definitely moving in that direction.
Related to your specific point I've introduced last Friday a new $util variable
and move all utility methods from the XWiki class to that new class so that's
also a step in that direction... Of course right now the class size is still
the same since we have to go through a deprecation strategy...
If you're interested to help that would be most welcome.
{quote}
We've recently introduced a sendmail plugin:
It's using JavaMail and not commons email. Not sure why. Stephane (the author)
shoul be able to tell us why he choose javamail.
{quote)
Thanks
-Vincent
> eMail (XWiki.sendMessage) defaults to illegal SMTP HELO
> -------------------------------------------------------
>
> Key: XWIKI-950
> URL: http://jira.xwiki.org/jira/browse/XWIKI-950
> Project: XWiki Platform
> Issue Type: Bug
> Components: Other
> Affects Versions: 1.0 B5
> Environment: Linux Java1.5 Java1.6 Tomcat55 PostgreSql
> Reporter: Tom Oehser
> Fix For: Future
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> SMTP HELO must (according to SMTP spec) be a Domain, (like 'jira.xwiki.org').
> Xwiki is defaulting it (if smtp_login is not set) to "XWiki
> VersionInformation" in XWiki.sendMessage().
> Probably it should use InetAddress.getLocalHost().getHostName() for the
> default domain.
> It might not even need the smtp_login configuration,
> InetAddress.getLocalHost().getHostName() may always be correct for the SMTP
> HELO.
> This was discovered because the Exim4 MTA is smart enough to reject
> HELO XWiki version 1.0-beta-5.2310
> -Tom
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.xwiki.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
notifications mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/notifications
