[
https://issues.apache.org/jira/browse/YETUS-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated YETUS-89:
----------------------------
Attachment: YETUS-89.00.patch
Attaching a patch, but it's not tested yet.
This is because the below code feels strange to me:
{code:title=dev-support/test-patch.d/jira.sh}
145 relativeurl=$(${AWK} 'match($0,"/secure/attachment/[0-9]*/[^\"]*"){print
substr($0,RSTART,RLENGTH)}' "${PATCH_DIR}/jira" |
146 ${GREP} -v -e 'htm[l]*$' | sort | tail -1 | ${SED} -e 's,[ ]*$,,g')
147 PATCHURL="${JIRA_URL}${relativeurl}"
148 if [[ ! ${PATCHURL} =~ \.patch$ ]]; then
149 guess_patch_file "${PATCH_DIR}/patch"
150 if [[ $? == 0 ]]; then
151 yetus_debug "The patch ${PATCHURL} was not named properly, but it
looks like a patch file. Proceeding, but issue/branch matching might go awry."
152 add_vote_table 0 patch "The patch file was not named according to
${PROJECT_NAME}'s naming conventions. Please see ${HOW_TO_CONTRIBUTE} for
instructions."
153 fi
154 fi
155 echo "${input} patch is being downloaded at $(date) from"
156 echo "${PATCHURL}"
157 add_footer_table "JIRA Patch URL" "${PATCHURL}"
158 jira_http_fetch "${relativeurl}" "${fileloc}"
{code}
guess_patch_file at line 149 seems too early, because the patch is not
downloaded until line 158.
(Precisely, it can be also downloaded at line 133, but the function returns
immediately after it)
Also, "$\{fileloc}" seems better than "$\{PATCH_DIR}/patch". Are these correct?
> Variable name "HOW_TO_CONTRIBUTE" is misleading
> -----------------------------------------------
>
> Key: YETUS-89
> URL: https://issues.apache.org/jira/browse/YETUS-89
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Reporter: Kengo Seki
> Priority: Trivial
> Labels: newbie
> Attachments: YETUS-89.00.patch
>
>
> {code}
> HOW_TO_CONTRIBUTE="https://yetus.apache.org/documentation/latest/precommit-patchnames";
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
