Kengo Seki created YETUS-150:
--------------------------------

             Summary: If resetrepo option is not specified in re-exec mode, 
test-patch succeeds even though -1 is voted
                 Key: YETUS-150
                 URL: https://issues.apache.org/jira/browse/YETUS-150
             Project: Yetus
          Issue Type: Bug
          Components: Test Patch
            Reporter: Kengo Seki


I tried this command,

{code}
[sekikn@mobile yetus]$ precommit/test-patch.sh --build-tool=nobuild --debug 
--plugins=all YETUS-78
{code}

and got this error message,

{code}
[Mon Nov  2 00:40:58 JST 2015 DEBUG]: can't destructively change the working 
directory. run with '--resetrepo' please. :(
[Mon Nov  2 00:40:58 JST 2015 DEBUG]: Stop clock
[Mon Nov  2 00:40:58 JST 2015 DEBUG]: add_vote_table -1 precommit Couldn't test 
precommit changes because we aren't configured to destructively change the 
working directory.
{code}

...but the command succeeded despite the above message.

{code}
+1 overall

 ____                              _ 
/ ___| _   _  ___ ___ ___  ___ ___| |
\___ \| | | |/ __/ __/ _ \/ __/ __| |
 ___) | |_| | (_| (_|  __/\__ \__ \_|
|____/ \__,_|\___\___\___||___/___(_)
                                     


| Vote |      Subsystem |  Runtime   | Comment
============================================================================
|   0  |        reexec  |  0m 04s    | precommit patch detected. 
|  +1  |       @author  |  0m 00s    | The patch does not contain any @author 
|      |                |            | tags.
|  +1  |    shellcheck  |  0m 00s    | There were no new shellcheck issues. 
|  +1  |    whitespace  |  0m 00s    | Patch has no whitespace issues. 
|      |                |  0m 08s    | 
{code}

Should test-patch fail in such a case?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to