[ 
https://issues.apache.org/jira/browse/YETUS-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985823#comment-14985823
 ] 

Allen Wittenauer commented on YETUS-148:
----------------------------------------

bq. And the above code may be unnecessary, because most options seem to be 
passed to the docker container via ${TESTPTCHMODE}.

That's true for test-patch running in the container. That's not true for the 
test-patch-docker driver script though...

> Wrong variable name ${TP_SHELL_SCRIPT_DEBUG}
> --------------------------------------------
>
>                 Key: YETUS-148
>                 URL: https://issues.apache.org/jira/browse/YETUS-148
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Kengo Seki
>            Assignee: Kengo Seki
>         Attachments: YETUS-148.00.patch
>
>
> {code:title=precommit/test-patch.sh}
> 1541     if [[ ${TP_SHELL_SCRIPT_DEBUG} = true ]]; then
> 1542       debugflag="--debug"
> 1543     fi
> {code}
> {code}
> [sekikn@mobile yetus]$ grep -r SHELL_SCRIPT_DEBUG precommit
> precommit/core.d/00-yetuslib.sh:  if [[ "${YETUS_SHELL_SCRIPT_DEBUG}" = true 
> ]]; then
> precommit/core.d/01-common.sh:  YETUS_SHELL_SCRIPT_DEBUG=false
> precommit/core.d/01-common.sh:        YETUS_SHELL_SCRIPT_DEBUG=true
> precommit/test-patch-docker/test-patch-docker.sh:  if [[ 
> "${YETUS_SHELL_SCRIPT_DEBUG}" = true ]]; then
> precommit/test-patch-docker/test-patch-docker.sh:        
> YETUS_SHELL_SCRIPT_DEBUG=true
> precommit/test-patch.sh:  if [[ "${YETUS_SHELL_SCRIPT_DEBUG}" = true ]]; then
> precommit/test-patch.sh:    if [[ ${TP_SHELL_SCRIPT_DEBUG} = true ]]; then
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to