[ 
https://issues.apache.org/jira/browse/YETUS-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985897#comment-14985897
 ] 

Allen Wittenauer commented on YETUS-57:
---------------------------------------

Sorry, I just realized this isn't the correct fix.  I misled you. :( Let's see 
if I can clarify.

 Currently, test-patch on hadoop jenkins has a directory structure that looks 
like:

BASEDIR/PATCH_DIR/BINDIR

This patch definitely avoids the current problem by checking if PATCH_DIR is 
inside BASEDIR. But it won't fix the problem if the directory structure is:

BASEDIR
PATCH_DIR/BINDIR

So we should probably check for the PATCH_DIR/BINDIR combo rather than the 
BASEDIR/PATCH_DIR combo.

> empty patch_dir if not in re-exec mode?
> ---------------------------------------
>
>                 Key: YETUS-57
>                 URL: https://issues.apache.org/jira/browse/YETUS-57
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Kengo Seki
>         Attachments: YETUS-57.00.patch, YETUS-57.01.patch, YETUS-57.02.patch
>
>
> test-patch behaves in surprising ways if the patch processing directory isn't 
> empty on execution.  This should probably be fixed, keeping in mind that 
> reexec mode will place some things there.  We should probably check if we are 
> re-execing and if not, either error or clean it out.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to