[
https://issues.apache.org/jira/browse/YETUS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated YETUS-172:
--------------------------------
Description: Most of the modules in the Hadoop codebase depend on the
hadoop-maven-plugins module as a pre-requisite. This is not currently captured
in the personality file. In one case, we saw that a Bash-only patch failed,
because a Bash-only patch doesn't need to run {{mvninstall}}. Therefore,
hadoop-maven-plugins isn't placed into the isolated Maven repo for that
pre-commit run. (was: When Yetus runs a pre-commit patch on Hadoop, and it
detects changes in Bash code, it activates the {{shelltest}} Maven profile for
the build to run BATS tests. This profile exists in Hadoop trunk, but not
branch-2. For a branch-2 patch on bash scripts, this will cause the pre-commit
to fail. This issue tracks enhancing the Hadoop personality to skip the
{{shelltest}} profile on branches that do not support the profile.)
Summary: Hadoop personality does not capture the pre-requisite of
hadoop-maven-plugins. (was: Hadoop pre-commit with shell script patches fails
on branch-2, because shelltest Maven profile does not exist.)
Given that, it seems the real problem is that the Hadoop profile doesn't
capture the fact that hadoop-maven-plugins is a pre-requisite for a lot of the
other modules. It's somewhat of a coincidence that a bash-only patch surfaced
the problem, because a bash-only patch won't trigger {{mvinstall}} (which is
good and correct). Before the Maven repo isolation, the shared repo would have
masked this problem, but that's no longer the case.
I've updated the issues title and description to match reality.
> Hadoop personality does not capture the pre-requisite of hadoop-maven-plugins.
> ------------------------------------------------------------------------------
>
> Key: YETUS-172
> URL: https://issues.apache.org/jira/browse/YETUS-172
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Reporter: Chris Nauroth
>
> Most of the modules in the Hadoop codebase depend on the hadoop-maven-plugins
> module as a pre-requisite. This is not currently captured in the personality
> file. In one case, we saw that a Bash-only patch failed, because a Bash-only
> patch doesn't need to run {{mvninstall}}. Therefore, hadoop-maven-plugins
> isn't placed into the isolated Maven repo for that pre-commit run.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
