Sean Busbey created YETUS-180:
---------------------------------
Summary: Ensure return codes are getting checked
Key: YETUS-180
URL: https://issues.apache.org/jira/browse/YETUS-180
Project: Yetus
Issue Type: Bug
Components: Test Patch
Affects Versions: 0.1.0
Reporter: Sean Busbey
we have a few places where we aren't checking return codes, particularly during
pipes.
e.g. in findbugs.sh:
{code}
+ module_findbugs_warnings=$("${FINDBUGS_HOME}/bin/filterBugs" -first \
+ "${PATCH_BRANCH}" \
+ "${warnings_file}.xml" \
+ "${warnings_file}.xml" \
+ | ${AWK} '{print $1}')
+
+ if [[ ${module_findbugs_warnings} -gt 0 ]] ; then
+ msg="${module} in ${PATCH_BRANCH} has ${module_findbugs_warnings} extant
Findbugs warnings."
{code}
ensure we're checking return code generally and PIPESTATUS specifically.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
