[
https://issues.apache.org/jira/browse/YETUS-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005526#comment-15005526
]
Kengo Seki commented on YETUS-179:
----------------------------------
Thanks for the comment, make sense. I'll update the patch.
bq. fonts won't be something we can include a header on and I'm surprised they
aren't recognized as binary (maybe we could exclude svg and woff2 generally?).
Strangely enough, woff2 is regarded as binary on my Mac.
{code}
[sekikn@mobile yetus]$ java -jar /tmp/apache-rat-0.11/apache-rat-0.11.jar
asf-site-src/source/assets/fonts
(snip)
Archives:
*****************************************************
Files with Apache License headers will be marked AL
Binary files (which do not require AL headers) will be marked B
Compressed archives will be marked A
Notices, licenses etc will be marked N
B asf-site-src/source/assets/fonts/FontAwesome.otf
B asf-site-src/source/assets/fonts/fontawesome-webfont.eot
!????? asf-site-src/source/assets/fonts/fontawesome-webfont.svg
B asf-site-src/source/assets/fonts/fontawesome-webfont.ttf
B asf-site-src/source/assets/fonts/fontawesome-webfont.woff
B asf-site-src/source/assets/fonts/fontawesome-webfont.woff2
B asf-site-src/source/assets/fonts/glyphicons-halflings-regular.eot
!????? asf-site-src/source/assets/fonts/glyphicons-halflings-regular.svg
B asf-site-src/source/assets/fonts/glyphicons-halflings-regular.ttf
B asf-site-src/source/assets/fonts/glyphicons-halflings-regular.woff
B asf-site-src/source/assets/fonts/glyphicons-halflings-regular.woff2
*****************************************************
{code}
Conversely, we perhaps need to exclude extensions other than svg and woff2 on
other platform. From another viewpoint, there might be a case to put a license
in svg because it's xml.
At this point, excluding fontawesome and glyphicons is enough for yetus, so I'm
thinking I won't add the exclude rules for svg and woff2 as for now.
> Clean up asflicense errors
> --------------------------
>
> Key: YETUS-179
> URL: https://issues.apache.org/jira/browse/YETUS-179
> Project: Yetus
> Issue Type: Bug
> Components: build
> Affects Versions: 0.1.0
> Reporter: Sean Busbey
> Assignee: Kengo Seki
> Priority: Blocker
> Attachments: YETUS-179.00.patch
>
>
> we have failures in pre-check from asf license
> * some third party software that won't come with a header
> * some dotfiles
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
