[
https://issues.apache.org/jira/browse/YETUS-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048622#comment-15048622
]
Allen Wittenauer commented on YETUS-216:
----------------------------------------
a) Running it on a fresh checkout produced this error:
{code}
rm: target/yetus-0.1.0-SNAPSHOT-bin.tar.gz: No such file or directory
{code}
Probably good to have a check for existence so people aren't confused by that
one. The other rm
b) This should be ${BASH_SOURCE-$0} to allow for pathing to work in a
guaranteed fashion:
{code}
"$(dirname "$(dirname "$0")")/lib/release-doc-maker/releasedocmaker.py" "${@}"
{code}
e.g.:
{code}
aw-mbp-work:yetus-0.1.0-SNAPSHOT aw$ cd bin
aw-mbp-work:bin aw$ export PATH=$(pwd):$PATH
aw-mbp-work:~ aw$ bash -x shelldocs
+++ dirname shelldocs
++ dirname .
+ ./lib/shelldocs/shelldocs.py
/tmp/yetus-0.1.0-SNAPSHOT/bin/shelldocs: line 17: ./lib/shelldocs/shelldocs.py:
No such file or directory
aw-mbp-work:~ aw$
{code}
c) For these:
{code}
creating staging area for convenience binary
creating convenience binary.
{code}
It'd be good to be told where those are, exactly.
Other than these minor issues, I think this is great!
> create script to make release artifacts
> ---------------------------------------
>
> Key: YETUS-216
> URL: https://issues.apache.org/jira/browse/YETUS-216
> Project: Yetus
> Issue Type: Task
> Components: build
> Affects Versions: 0.1.0
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Attachments: YETUS-216.0.patch, YETUS-216.1.patch, YETUS-216.2.patch,
> YETUS-216.3.patch
>
>
> it'll take as much effort to write docs on manually creating release
> artifacts as it will to make a build script that creates them, so make the
> script.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
