[
https://issues.apache.org/jira/browse/YETUS-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089391#comment-15089391
]
John Zhuge commented on YETUS-273:
----------------------------------
Thanks [~mzuehlke] for fixing it quickly.
An extra trailing whitespace was introduced in the patch. Fixed by the
following diff.
{noformat}
diff --git a/precommit/test-patch.d/findbugs.sh
b/precommit/test-patch.d/findbugs.sh
index abf169b..a9e9614 100755
--- a/precommit/test-patch.d/findbugs.sh
+++ b/precommit/test-patch.d/findbugs.sh
@@ -63,7 +63,7 @@ function findbugs_precheck
if [[ -z ${FINDBUGS_HOME} ]]; then
yetus_error "FINDBUGS_HOME was not specified."
status=1
- else
+ else
for exec in findbugs \
computeBugHistory \
convertXmlToText \
{noformat}
> Misleading warning messages when FINDBUGS_HOME is not set
> ---------------------------------------------------------
>
> Key: YETUS-273
> URL: https://issues.apache.org/jira/browse/YETUS-273
> Project: Yetus
> Issue Type: Improvement
> Reporter: John Zhuge
> Assignee: Marco Zühlke
> Priority: Trivial
> Attachments: YETUS-273.00.patch
>
>
> The warning messages are a little misleading when FINDBUGS_HOME is not set.
> {noformat}
> $ unset FINDBUGS_HOME
> $ ~/yetus/precommit/test-patch.sh --plugins="all" --dirty-workspace
> ~/tmp/HDFS-9522-005.patch
> /tmp/yetus-16516.16384 has been created
> Running in developer mode
> Processing: /Users/jzhuge/tmp/HDFS-9522-005.patch
> Patch file /Users/jzhuge/tmp/HDFS-9522-005.patch copied to
> /private/tmp/yetus-16516.16384
> ============================================================================
> ============================================================================
> Confirming git environment
> ============================================================================
> ============================================================================
> dirty workspace mode; applying against existing branch
> Testing patch on trunk.
> executable '/bin/findbugs' for 'findbugs' does not exist.
> executable '/bin/computeBugHistory' for 'computeBugHistory' does not exist.
> executable '/bin/convertXmlToText' for 'convertXmlToText' does not exist.
> executable '/bin/filterBugs' for 'filterBugs' does not exist.
> executable '/bin/setBugDatabaseInfo' for 'setBugDatabaseInfo' does not exist.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
