Sean Busbey created YETUS-296:
---------------------------------
Summary: docs only patch should not trigger unit tests
Key: YETUS-296
URL: https://issues.apache.org/jira/browse/YETUS-296
Project: Yetus
Issue Type: Bug
Components: Test Patch
Affects Versions: 0.1.0
Reporter: Sean Busbey
Right now the maven personality claims that docs only changes require a run of
unit tests (see HBASE-14810 and [this run on yetus
master|https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-HBASE-Build/355/console]
for example).
{code}
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: Determining needed tests for
src/main/asciidoc/_chapters/configuration.adoc
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: Using builtin mvn personality_file_tests
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: tests/javadoc+units:
src/main/asciidoc/_chapters/configuration.adoc
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: Testing if javac has been enabled by user
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: verify_plugin_enabled: processing all
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: Post-parsing: checking javac = javac
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: Adding javac to NEEDED_TESTS
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: Testing if javadoc has been enabled by
user
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: verify_plugin_enabled: processing all
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: Post-parsing: checking javadoc = javadoc
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: Adding javadoc to NEEDED_TESTS
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: Testing if unit has been enabled by user
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: verify_plugin_enabled: processing all
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: Post-parsing: checking unit = unit
[Fri Jan 29 21:21:06 UTC 2016 DEBUG]: Adding unit to NEEDED_TESTS
{code}
It's definitely true that things under src/main (or src/test) might require
unit tests even if they aren't under src/main/java, so I'm not sure what the
generalized approach here is. Maybe a white list of things we know don't
require it? (e.g. asciidoc and docbook) Along with a hook for personalities to
impact it? Or maybe we just need to alter the default file filter rule and doc
how personalities override it?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
