[ 
https://issues.apache.org/jira/browse/YETUS-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169927#comment-15169927
 ] 

Marco Zühlke commented on YETUS-144:
------------------------------------

The shelldocs in {{checkstyle.sh}} suffer from an copy and paste bug.
All 3 functions carry the same description:
{code}
+## @description  initialize the checkstyle plug-in
{code}

And why is the guarding condition the existence of the {{maven_add_install}} 
function. Isn't the function always there ?
{code}
if declare -f maven_add_install >/dev/null 2>&1; then
{code}
I would have checked if the BUILDTOOL is maven ?

> mvn install usually required on mvn builds
> ------------------------------------------
>
>                 Key: YETUS-144
>                 URL: https://issues.apache.org/jira/browse/YETUS-144
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>             Fix For: 0.2.0
>
>         Attachments: YETUS-144.00.patch, YETUS-144.01.patch, 
> YETUS-144.02.patch
>
>
> Found an interesting side effect of YETUS-137 this morning.  Since the 
> compile step was now skipped, the mvn install was also skipped.  As a result, 
> mvn test broke if the mvn cache was new.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to