[
https://issues.apache.org/jira/browse/YETUS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178376#comment-15178376
]
Sean Busbey edited comment on YETUS-321 at 3/3/16 7:00 PM:
-----------------------------------------------------------
This sounds great. Can we break it into a few subtasks to make reviews go
faster?
I'm thinking:
* split option parsing and validation out of main
* refactor for Linter class
* new options cli flag
But am happy to go with whatever arrangement works better for you
[~andrew.wang].
One other bit:
bq. lint filters will be specified via a new --lint-opts flag, since that's the
only compatible-ish way of doing the filter parsing. optparse cannot handle
optional values.
Can we work around this using the [wrapper
scripts|https://github.com/apache/yetus/blob/0.1.0/build.sh#L122] we put into
the binary artifact?
Right now they're generic for all the utilities, but we could make them
tool-specific (and move them out of build.sh). That would mean that the one for
releasedoc maker could intercept {{\-\-lint}} and turn it into {{--lint=all}}.
This would maintain compatibility for atleast those folks who don't invoke the
python directly.
was (Author: busbey):
This sounds great. Can we break it into a few subtasks to make reviews go
faster?
I'm thinking:
* split option parsing and validation out of main
* refactor for Linter class
* new options cli flag
But am happy to go with whatever arrangement works better for you
[~andrew.wang].
One other bit:
bq. lint filters will be specified via a new --lint-opts flag, since that's the
only compatible-ish way of doing the filter parsing. optparse cannot handle
optional values.
Can we work around this using the [wrapper
scripts|https://github.com/apache/yetus/blob/0.1.0/build.sh#L122] we put into
the binary artifact?
Right now they're generic per utility, but we could make them tool-specific
(and move them out of build.sh). That would mean that the one for releasedoc
maker could intercept {{--lint}} and turn it into {{--lint=all}}. This would
maintain compatibility for atleast those folks who don't invoke the python
directly.
> Add flag to releasedocmaker.py to ignore missing component in lint mode
> -----------------------------------------------------------------------
>
> Key: YETUS-321
> URL: https://issues.apache.org/jira/browse/YETUS-321
> Project: Yetus
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: yetus-321.001.patch, yetus-321.002.patch
>
>
> Not all projects require the "component" field in JIRA. For these projects,
> it would be nice to ignore the "missing component" errors in lint mode.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
