[
https://issues.apache.org/jira/browse/YETUS-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204831#comment-15204831
]
Andrew Wang commented on YETUS-326:
-----------------------------------
Can anyone help me with running test-patch.sh locally against yetus? I tried
some invocation like:
{noformat}
-> % ./precommit/test-patch.sh --dirty-workspace --plugins="pylint"
~/patches/YETUS-326.002.patch
...
ERROR: pom.xml is not found. Make sure the target is a maven-based project.
{noformat}
I ran pylint myself and do not see these errors:
{noformat}
-> % pylint --version
pylint 1.5.4,
astroid 1.4.4
Python 2.7.3 (default, Jun 22 2015, 19:33:41)
[GCC 4.6.3]
-> % pylint release-doc-maker/releasedocmaker.py
************* Module releasedocmaker
W:101, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:102, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:103, 0: Bad indentation. Found 6 spaces, expected 8 (bad-indentation)
W:104, 0: Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
W:105, 0: Bad indentation. Found 6 spaces, expected 8 (bad-indentation)
C:106, 0: Wrong hanging indentation (add 2 spaces).
'markdown' : markdownsanitize(_str),
^ | (bad-continuation)
C:107, 0: Exactly one space required after comma
}.get(fmt.group(1),textsanitize(_str))
^ (bad-whitespace)
C:489, 0: Line too long (107/100) (line-too-long)
W: 41, 0: Anomalous backslash in string: '\<'. String constant might be missing
an r prefix. (anomalous-backslash-in-string)
W: 41, 0: Anomalous backslash in string: '\!'. String constant might be missing
an r prefix. (anomalous-backslash-in-string)
W: 41, 0: Anomalous backslash in string: '\-'. String constant might be missing
an r prefix. (anomalous-backslash-in-string)
W: 41, 0: Anomalous backslash in string: '\-'. String constant might be missing
an r prefix. (anomalous-backslash-in-string)
W: 41, 0: Anomalous backslash in string: '\-'. String constant might be missing
an r prefix. (anomalous-backslash-in-string)
W: 41, 0: Anomalous backslash in string: '\-'. String constant might be missing
an r prefix. (anomalous-backslash-in-string)
W: 41, 0: Anomalous backslash in string: '\>'. String constant might be missing
an r prefix. (anomalous-backslash-in-string)
W: 37, 4: Redefining built-in 'set' (redefined-builtin)
C: 1, 0: Missing module docstring (missing-docstring)
C: 64, 0: Missing function docstring (missing-docstring)
C: 67, 0: Missing function docstring (missing-docstring)
C: 77, 0: Missing function docstring (missing-docstring)
C: 88, 0: Missing function docstring (missing-docstring)
C:100, 0: Missing function docstring (missing-docstring)
C:109, 0: Missing function docstring (missing-docstring)
C:165, 4: Missing method docstring (missing-docstring)
R:140, 0: Too few public methods (1/2) (too-few-public-methods)
R:168, 0: Too few public methods (0/2) (too-few-public-methods)
C:201, 4: Missing method docstring (missing-docstring)
C:204, 4: Missing method docstring (missing-docstring)
C:207, 4: Missing method docstring (missing-docstring)
C:218, 4: Missing method docstring (missing-docstring)
C:225, 4: Missing method docstring (missing-docstring)
C:232, 4: Missing method docstring (missing-docstring)
C:238, 4: Missing method docstring (missing-docstring)
C:241, 4: Missing method docstring (missing-docstring)
C:248, 4: Missing method docstring (missing-docstring)
C:255, 4: Missing method docstring (missing-docstring)
C:275, 4: Missing method docstring (missing-docstring)
C:289, 4: Missing method docstring (missing-docstring)
C:300, 4: Missing method docstring (missing-docstring)
C:305, 4: Missing method docstring (missing-docstring)
C:310, 4: Missing method docstring (missing-docstring)
C:318, 4: Missing method docstring (missing-docstring)
C:320, 8: Consider using enumerate instead of iterating with range and len
(consider-using-enumerate)
E:364,15: Instance of 'bool' has no 'has_key' member (no-member)
C:389, 4: Missing method docstring (missing-docstring)
C:408, 4: Missing method docstring (missing-docstring)
C:417, 4: Missing method docstring (missing-docstring)
C:422, 4: Missing method docstring (missing-docstring)
C:427, 4: Missing method docstring (missing-docstring)
C:536, 0: Missing function docstring (missing-docstring)
R:536, 0: Too many local variables (30/15) (too-many-locals)
W:558, 8: Using the global statement (global-statement)
R:536, 0: Too many branches (34/12) (too-many-branches)
R:536, 0: Too many statements (141/50) (too-many-statements)
C: 37, 4: standard import "from sets import Set as set" comes before "import
simplejson as json" (wrong-import-order)
{noformat}
> Make releasedocmaker.py lint filters configurable
> -------------------------------------------------
>
> Key: YETUS-326
> URL: https://issues.apache.org/jira/browse/YETUS-326
> Project: Yetus
> Issue Type: Sub-task
> Components: Release Doc Maker
> Affects Versions: 0.1.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: YETUS-326.001.patch, YETUS-326.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
