[
https://issues.apache.org/jira/browse/YETUS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207944#comment-15207944
]
Allen Wittenauer edited comment on YETUS-156 at 3/23/16 6:19 AM:
-----------------------------------------------------------------
Ugh. I've hit a huge performance pothole:
{code}
CHANGED_FILES=($(${GIT} ls-files))
{code}
... is *extremely* fast. It takes all of the known files in git and shoves
them into an array. HOWEVER, it breaks horribly if there is a space in the
filename. Ok, fine. We'll use git ls-files -z... except bash doesn't support
IFS being set to null.
Right now, I've re-written this to be a while/read loop. It's so slow for
Hadoop's ~9k files I added a counter to show that it was actually working.
(Using pipes here are problematic due to them being subshells.... ugh.)
was (Author: aw):
Ugh. I've hit a huge performance pothole:
{code}
CHANGED_FILES=($(${GIT} ls-files))
{code}
... is *extremely* fast. It takes all of the known files in git and shoves
them into an array. HOWEVER, it breaks horribly if there is a space in the
filename. Ok, fine. We'll use git ls-files -z... except bash doesn't support
IFS being set to null.
Right now, I've re-written this to be a while/read loop. It's so slow for
Hadoop's ~9k files I added a counter to show that it was actually working.
I'm going to try and use a sed after the git ls-files -z to turn the NULL into
something that IFS can parse. Probably LF.
> build driver
> ------------
>
> Key: YETUS-156
> URL: https://issues.apache.org/jira/browse/YETUS-156
> Project: Yetus
> Issue Type: New Feature
> Components: Test Patch
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Attachments: YETUS-156.00.patch
>
>
> it might be useful to create something that runs test-patch's plug-ins as
> part of a build process. In other words, perform a full source build,
> generating reports from checkstyle, findbugs, shellcheck, multi-jdk, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
