[ 
https://issues.apache.org/jira/browse/YETUS-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219955#comment-15219955
 ] 

Allen Wittenauer commented on YETUS-362:
----------------------------------------

It's a bit trickier than that, unfortunately.

The precommit-admin job triggers the precommit-hadoop-build job which then 
calls Yetus. There are no hooks in precommit-admin for github, so all 
precommit-hadoop jobs are technically triggered by a JIRA change.

Yetus pulls down various bits from JIRA, including the issue content.  If it 
finds any mention of a github PR, it assumes that this JIRA was triggered by 
that PR.  This assumption was made because of the rarity of github PRs in the 
Hadoop-space.

Ideally, Yetus could support "dual input" like this without an assumption is to 
do date comparisons.  However, the last time I looked at the ASF's github 
hooks, it only ever puts *one* message when the PR is created.  All of the 
remaining messages are comments left on the PR.

Without changing the ASF's github hooks, I'm not sure it is possible to fix 
this to anyone's satisfaction.

But: there is a workaround.  If the comment that contains the PR is edited such 
that the URL no longer matches the regex that Yetus uses, it will fall back to 
pulling the patch.  For the referenced JIRA, changing the https://blah.patch 
line to something not saying that, e.g., removing the https part, will miss the 
regex.

> Attached patch in jira is not used by jenkins if there is a corresponding 
> pull request.
> ---------------------------------------------------------------------------------------
>
>                 Key: YETUS-362
>                 URL: https://issues.apache.org/jira/browse/YETUS-362
>             Project: Yetus
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Akira AJISAKA
>
> When a patch is attached in HDFS-9263, Jenkins precommit downloads the other 
> patch in the corresponding github pull request. Jenkins should download the 
> attached patch instead of the patch in github if the precommit is triggered 
> by jira.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to