[ 
https://issues.apache.org/jira/browse/YETUS-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266103#comment-15266103
 ] 

Kengo Seki commented on YETUS-305:
----------------------------------

I tried git 1.7.9 and 1.7.10. 1.7.9 failed as expected, but 1.7.10 succeeded in 
my environment.

{code}
[sekikn@mobile asf-site-src]$ export PATH=/Users/sekikn/git_1.7.9/bin:$PATH
[sekikn@mobile asf-site-src]$ git version
git version 1.7.9
[sekikn@mobile asf-site-src]$ bundle exec middleman build
Building docs for release 0.1.0
        cleaning up output directories in ../target
        cloning from tag.
building docs failed to for 0.1.0.
[sekikn@mobile asf-site-src]$ export PATH=${PATH/1.7.9/1.7.10}
[sekikn@mobile asf-site-src]$ git version
git version 1.7.10
[sekikn@mobile asf-site-src]$ bundle exec middleman build
Building docs for release 0.1.0
        cleaning up output directories in ../target
        cloning from tag.
        setting up markdown docs
        generating javadocs
Building docs for release 0.2.0
        cleaning up output directories in ../target
        cloning from tag.
        setting up markdown docs
        generating javadocs
Building docs for release 0.2.1
        cleaning up output directories in ../target
        cloning from tag.
        setting up markdown docs
        generating javadocs
{code}

I think the error Sean encountered was somewhat irrelevant and we can regard 
1.7.10 is the minimum version.

> site building should check for minimum git version
> --------------------------------------------------
>
>                 Key: YETUS-305
>                 URL: https://issues.apache.org/jira/browse/YETUS-305
>             Project: Yetus
>          Issue Type: Improvement
>          Components: website and documentation
>    Affects Versions: 0.1.0, 0.2.0
>            Reporter: Sean Busbey
>            Priority: Minor
>
> When building per-release documentation, we do some git magic:
> {code}
>   puts "\tcloning from tag."
>   `(cd "#{output}" && git clone --depth 1 --branch "#{version}" 
> --single-branch -- "#{GITREPO}" "build-#{version}") 
> >"#{output}/#{version}_git_checkout.log" 2>&1`
>   unless $?.exitstatus == 0
>     abort("building docs failed to for #{version}.")
>   end
> {code}
> This doesn't work with older versions of git:
> {code}
> busbey2-MBA:asf-site-src busbey$ rvm use 2.2.0@yetus-site
> Using /Users/busbey/.rvm/gems/ruby-2.2.0 with gemset yetus-site
> gbusbey2-MBA:asf-site-src busbey$ git --version
> git version 1.7.10.2 (Apple Git-33)
> busbey2-MBA:asf-site-src busbey$ bundle exec middleman build
> Building docs for release 0.1.0
>       cleaning up output directories in ../target
>       cloning from tag.
> building docs failed to for 0.1.0.
> busbey2-MBA:asf-site-src busbey$ source ~/.bashrc
> busbey2-MBA:asf-site-src busbey$ git --version
> git version 2.1.0
> busbey2-MBA:asf-site-src busbey$ bundle exec middleman build
> Building docs for release 0.1.0
>       cleaning up output directories in ../target
>       cloning from tag.
>       setting up markdown docs
>       generating javadocs
>    identical  publish/assets/css/bootstrap-theme.css
>    identical  publish/assets/css/bootstrap-theme.min.css
>    identical  publish/assets/css/bootstrap.css
>    identical  publish/assets/css/bootstrap.min.css
>    identical  publish/assets/css/font-awesome.css
>    identical  publish/assets/css/font-awesome.min.css
>    identical  
> publish/documentation/in-progress/audience-annotations-apidocs/stylesheet.css
>    identical  publish/documentation/0.1.0/audience-annotation
>    ....SNIP....
> {code}
> we should check the git version and bail early.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to